Repository navigation
Tests restore the appearance setting they change - #1136
Merged
Merged
Conversation
ConsoleDarkInLightTests wrote the appearance key to the shared defaults. It now uses an isolated suite through defaultAppStorage. A guard test fails if a test writes that key to the standard defaults again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix or feature
What and why
Problem. A full
swift testrun sometimes failed inShellInstallTestswith "left appearance in the shared test defaults".Cause.
ConsoleDarkInLightTests(from #1097) wrote theappearancekey to the standard defaults. The shared-defaults guard then failed whichever test ran next.Change. The test uses an isolated suite through
defaultAppStorage. A new guard test fails if a test writes that key to the standard defaults again.Follows #1097.
Checked
AppearanceKeyGuardTests.