Repository navigation
Make every view of the UI overhaul reachable - #1129
Merged
Merged
Conversation
The controller's focus ring and the selected tile's underline were solid near-black in Light. They now use the Light primary at 0.55 through the LauncherPalette tokens focusRing and selectionUnderline. Dark keeps the cream.
Supported games was only in a game's Manage menu and the empty library. It is now a secondary button in the collection header before Sort (its symbol only below 1100 pt), and no longer in the Manage menu. Console mode reaches it from the menu's Library page: a page with the search's on-screen keyboard, the notes on A and the owned game's page. Cmd+F in the desktop sheet focuses its search, and a controller reaches its rows. New texts in all ten languages, reachability tests and captures.
The home screen and a game's page show the quick menu on minus, and a game's page shows X Play and Y Game options. X resumes a paused game. Y no longer deletes in the search: B deletes a letter while there is one and leaves once the field is empty, and its hint says which. Swap A and B is also a switch on the Controllers page. The desktop's unused console entry button is removed. Adds the texts of this PR in all ten languages.
With A B X Y moving together the diamond's toolbar has a Hold or Toggle button per key, so a controller sets them without moving the keys apart. Toggled keys carry a mark in the editor, and the Touch controls row lists them. The Switch 2 badge and its memory note show under the state at the top of a game's settings, where the hidden header had them.
Patch 0124 reads the menu's title, Controller layout, Keys that toggle and None from DM_GAME_MENU_TEXT, English when a line is missing. The shell passes it with every launch. An iPhone or iPad build of a game's own app gets it in its bundled env file, in the launcher's language.
Options (Xbox View, PlayStation Create, Nintendo Minus) opens the gear's settings over the library and over a game's settings, and closes them again. It does nothing over another panel or dialog, and the shell takes no controller input while a game runs. The library and the controller help show it in their hints. A pad without Options keeps the gear in the focus order.
The demo gets a QA Options button and a --switch2 flag.
The game-menu-text patch is 0123 now, the next free number after main's 0122.
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix or feature
What and why
Follows #1097.
Problem. Several views of the UI overhaul were hidden or unreachable: Supported games, console mode's quick menu and game page buttons, Hold or Toggle with a controller, the Switch 2 badge in the shell.
Cause. #1097 placed some entries where a player would not look, and some had no hint or no way in.
Change. Every item of the audit is now reachable and visible. Supported games sits in the collection header and console mode's Library page. Console mode shows its buttons. The shell and the in-game menu got the missing pieces.
Details: the audit and the fixes
I checked every view, card and action #1097 added or moved, by how a user reaches it with mouse and keyboard, a controller, console mode and iOS.
Desktop:
Console mode:
ConsoleEntryButtonis removed. The desktop has visible ways in (View > Console Mode, the Select hint, the prompt).iOS shell:
In-game menu (engine patch 0124,
Upstream-Status: pending, builds on 0121):DM_GAME_MENU_TEXT, English when missing.Not changed, by design: stick deadzones stay a desktop card (the values reach games started from console mode). Light and System stay Mac only, the shell is dark.
New texts are in all 10 languages. The iOS catalogs are regenerated.
Checked
swift test1108 app tests plus NXCore 304 and NXModel 204, 0 failures. frontend-ios package tests pass.tools/tests220 OK. frontend-qt 426 OK.python3 tools/engine.py check: 88 patches apply. The engine'stest_env_switchespasses.SupportedGamesReachabilityTests,ConsoleHintsReachabilityTests,GameMenuTextTests,theDiamondsKeysGetAModeWhileTheyMoveTogether,theInGameMenuWordsGoWithEveryLaunch,testOptionsOpensTheShellSettings,ShellSettingsShortcutTests,testFocusRingIsQuieterInLightAndUnchangedInDark.Screenshots
Library, Light, before and after:
At 900 pt the button keeps its symbol and Sort keeps its menu:
Focus on the Library tab in Light, before and after:
Console mode, Library page before and after, and the new Supported games page:
Console mode home screen before and after (− Quick menu in the hints), a game's page and the search with their new hints:
Scope
dm/,scripts/,docs/,ref/) is added to the repositorypending, it builds on 0121, which is not upstream yet