Repository navigation
Patches of the UI overhaul are forwarded to seedds/nxnative - #1099
Merged
Merged
Conversation
v0lumehi
added
bug
0115 and 0117 extend fork-only parts upstream declined (#492, #488). 0118, 0120 and 0121 build on the touch patches 0065 to 0070 and 0090, 0122 on seedds/nxnative#221. They are forwarded once those land.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix or feature
What and why
Problem. Two patches of the UI overhaul still said
pending seedds/nxnative#TBD. Follows #1097.Change. Their headers now name the seedds PRs:
The other six patches of #1097 stay pending. They build on fork-only patches or on pending ones that seedds does not have, so they cannot go upstream alone: 0115 (needs 0047 and 0077), 0117 (needs 0008), 0118, 0120 and 0121 (need the touch patches 0065 to 0070), 0122 (needs 0081, seedds/nxnative#221).
Checked
python3 tools/engine.py checkpasses. Headers only.