Repository navigation
Round the focus ring of the Play and game settings buttons - #1067
Merged
Merged
Conversation
The ring used a corner radius of 16 on a capsule and a circle, so its corners were smaller than the button's. A large radius makes it follow the shape. Part of #1026
Contributor
|
Thanks for picking up the ring-shape fix. I have a local follow-up for the remaining #1026 controller issues: reaching the Settings gear and game-language row, leaving mapping with B, using Reset, and keeping input with the active sheet or dialog. It includes simulator regression checks; physical-controller validation is still pending. There’s overlap with your two radius changes, so I’d plan to build on #1067 once it lands and keep the follow-up focused on the remaining issues. Does that order work for you? |
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1026
The Play button is a capsule and the game settings button is a circle, but both passed a radius of 16 to the focus ring. Both now pass 100, and the ring clamps to the button shape. The other points of #1026 need a device and stay open.
There is no test, because the repo has no ring shape test. I did not run anything locally. Before and after screenshots are still to be added.