Repository navigation
A Frame rate choice for present_interval display games (Overcooked, Monster Train 2) - #1044
Closed
TeeJayBaker wants to merge 3 commits into
Closed
TeeJayBaker wants to merge 3 commits into
TeeJayBaker wants to merge 3 commits into
Conversation
4 of 5 tasks
…102, 0103) Rebased on main. 0102 (Unity keys): unity_pass_drawn returns early when unity_skip_passes is empty, so a profile without the key reads no pass tag. 0103: the Overcooked profile, refreshed on c78d7375. The Frame rate patch moves to its own pull request. GAMES.md, GAMES.it.md and GAMES.zh-CN.md get the Overcooked row, and the profile counts are 148 (the 147 rows of the tables, plus Overcooked).
…vercooked, Monster Train 2) Split out of LNPANDY#372, on top of it (it edits Overcooked's profile files). Issue LNPANDY#1043.
…very language The launcher draws settings.tsv's rows with its own strings, and LaunchOptionsTests wants one for each row and option. The labels are those of DM_FPS_TARGET's Frame rate, 30 fps and 60 fps.
TeeJayBaker
force-pushed
the
overcooked-frame-rate
branch
from
November 9, 2026 15:20
1d0f854 to
f223e66
Compare
1 of 2 tasks
Collaborator
|
Thank you @TeeJayBaker. Your change is part of #1097, the launcher UI overhaul, with you as co-author. Closing this one in favor of it. Please have a look there if something of yours is missing or changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix or feature
Feature from outside: #1043.
What and why
Monster Train 2 and Overcooked! All You Can Eat have
present_interval displayand nofps_target, so they run at 60 fps with no 30 fps choice in the launcher (onlyDM_PRESENT_INTERVAL=gamein an env file). Patch0104adds a Frame rate row forDM_PRESENT_INTERVAL(30 fps =game, 60 fps =display, defaultdisplay), shown forDM_GAME_PRESENT_DISPLAY==1&DM_GAME_FPS_TARGET==0, and letssettings.pytake several shown conditions joined by&. A game withfps_targetkeeps its one Frame rate row. The launcher draws the row from the game'slauncher.jsonwith its own strings, sofrontend/l10ngets the label and both options in all seven languages, the same words asDM_FPS_TARGET's Frame rate, 30 fps and 60 fps.Split out of #372 and stacked on it, because it edits Overcooked's profile files. The first commit here is #372's. This PR's change is the last commit.
Checked
python3 tools/engine.py check(70 patches apply cleanly to c78d7375bea9). Inengine/:test_launcher_settings.py(Monster Train 2 and Overcooked get the row; Monster Hunter Rise, display withfps_target, keeps onlyDM_FPS_TARGET; Super Mario Bros. Wonder gets neither),test_settings.py,test_docs.py. Infrontend/:swift test(LaunchOptionsTestschecks that every row has its strings;GermanLocalizationTestsnow lists the two fps options, which read the same in German).0100F28011892000, 1.0.11) from the launcher on an M1 Pro, macOS 26.7.2. Launch options shows Frame rate, and with 30 fps chosen the log readslauncher: env DM_PRESENT_INTERVAL=game (saved choice)andinterval mode game (original semantics). Not checked: Monster Train 2, iOS.Screenshots
None. The row is drawn like every other choice, with the existing Frame rate wording.
Scope
dm/,scripts/,docs/,ref/) is added to the repository: a change there is a patch inpatches/(a commit inengine/, thentools/engine.py export, andtools/engine.py checkpasses), with itsUpstream-Statusforwarded seedds/nxnative#..., orpendinguntil that PR is open