Skip to content

A Frame rate choice for present_interval display games (Overcooked, Monster Train 2) - #1044

Closed
TeeJayBaker wants to merge 3 commits into
LNPANDY:mainfrom
TeeJayBaker:overcooked-frame-rate
Closed

TeeJayBaker wants to merge 3 commits into
LNPANDY:mainfrom
TeeJayBaker:overcooked-frame-rate

Conversation

@TeeJayBaker

@TeeJayBaker TeeJayBaker commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Fix or feature

  • Fix
  • Feature

Feature from outside: #1043.

What and why

Monster Train 2 and Overcooked! All You Can Eat have present_interval display and no fps_target, so they run at 60 fps with no 30 fps choice in the launcher (only DM_PRESENT_INTERVAL=game in an env file). Patch 0104 adds a Frame rate row for DM_PRESENT_INTERVAL (30 fps = game, 60 fps = display, default display), shown for DM_GAME_PRESENT_DISPLAY==1&DM_GAME_FPS_TARGET==0, and lets settings.py take several shown conditions joined by &. A game with fps_target keeps its one Frame rate row. The launcher draws the row from the game's launcher.json with its own strings, so frontend/l10n gets the label and both options in all seven languages, the same words as DM_FPS_TARGET's Frame rate, 30 fps and 60 fps.

Split out of #372 and stacked on it, because it edits Overcooked's profile files. The first commit here is #372's. This PR's change is the last commit.

Checked

  • Tests: python3 tools/engine.py check (70 patches apply cleanly to c78d7375bea9). In engine/: test_launcher_settings.py (Monster Train 2 and Overcooked get the row; Monster Hunter Rise, display with fps_target, keeps only DM_FPS_TARGET; Super Mario Bros. Wonder gets neither), test_settings.py, test_docs.py. In frontend/: swift test (LaunchOptionsTests checks that every row has its strings; GermanLocalizationTests now lists the two fps options, which read the same in German).
  • Run on a Mac: Overcooked (0100F28011892000, 1.0.11) from the launcher on an M1 Pro, macOS 26.7.2. Launch options shows Frame rate, and with 30 fps chosen the log reads launcher: env DM_PRESENT_INTERVAL=game (saved choice) and interval mode game (original semantics). Not checked: Monster Train 2, iOS.

Screenshots

None. The row is drawn like every other choice, with the existing Frame rate wording.

Scope

  • No engine file (dm/, scripts/, docs/, ref/) is added to the repository: a change there is a patch in patches/ (a commit in engine/, then tools/engine.py export, and tools/engine.py check passes), with its Upstream-Status
  • A fix to the engine or a game profile also goes to seedds/nxnative as a PR in parallel: this PR's patch says forwarded seedds/nxnative#..., or pending until that PR is open
  • No keys, game files or data extracted from a game in the change or the attachments

@github-actions github-actions Bot added documentation Improvements or additions to documentation patch-queue Changes the patch queue or the upstream pin labels Nov 9, 2026
…102, 0103)

Rebased on main. 0102 (Unity keys): unity_pass_drawn returns early when
unity_skip_passes is empty, so a profile without the key reads no pass tag.
0103: the Overcooked profile, refreshed on c78d7375. The Frame rate patch
moves to its own pull request.

GAMES.md, GAMES.it.md and GAMES.zh-CN.md get the Overcooked row, and the
profile counts are 148 (the 147 rows of the tables, plus Overcooked).
…vercooked, Monster Train 2)

Split out of LNPANDY#372, on top of it (it edits Overcooked's profile files).
Issue LNPANDY#1043.
…very language

The launcher draws settings.tsv's rows with its own strings, and
LaunchOptionsTests wants one for each row and option. The labels are
those of DM_FPS_TARGET's Frame rate, 30 fps and 60 fps.
@TeeJayBaker
TeeJayBaker force-pushed the overcooked-frame-rate branch from 1d0f854 to f223e66 Compare November 9, 2026 15:20
@github-actions github-actions Bot added launcher The NX2Apple launcher app windows Windows (the Qt front end) labels Nov 9, 2026
@v0lumehi

v0lumehi commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Thank you @TeeJayBaker. Your change is part of #1097, the launcher UI overhaul, with you as co-author. Closing this one in favor of it. Please have a look there if something of yours is missing or changed.

@v0lumehi v0lumehi closed this Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation launcher The NX2Apple launcher app patch-queue Changes the patch queue or the upstream pin windows Windows (the Qt front end)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants