fix: reject unsafe Qwen3.8 graph-mode GDN reuse - #295
Draft
matthewygf wants to merge 2 commits into
Draft
matthewygf wants to merge 2 commits into
matthewygf wants to merge 2 commits into
Conversation
matthewygf
requested a deployment
to
ci-hardware
September 13, 2026 16:18 — with
GitHub Actions
Waiting
matthewygf
requested a deployment
to
ci-hardware
September 13, 2026 16:18 — with
GitHub Actions
Waiting
matthewygf
requested a deployment
to
ci-hardware
September 13, 2026 16:18 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #292 merged Qwen3.5-family GDN/MTP cache reuse into
dsv4_support_045. Its own acceptance evidence records truncated Qwen3.8-27B outputs after external-cache reuse in graph mode, including a four-token prefill tail with MTP3. The eager equivalents passed.The merged validator nevertheless accepts
qwen3_5_texttargets withenforce_eager=False, and its tests explicitly treated that combination as supported. This allows a known silent-correctness failure to start.This draft:
qwen3_5_textGDN/MTP path;qwen3_5_moe_textpath;Validation
python -m py_compilepassed for both changed Python files.isort==6.0.1 --check-onlypassed.ruff==0.11.7 checkpassed.ruff==0.11.7 format --checkpassed.git diff --checkpassed.The full pytest target could not run locally because PyTorch, vLLM, LMCache, and pytest are unavailable in the runner. Repository CI and NPU validation are still required.
Risk
The behavior change is limited to Qwen3.5-family MTP configurations whose target model type is
qwen3_5_textand whose target is not eager. Those deployments will now fail during configuration validation and must use--enforce-eager.This is intentionally conservative: the shared model-type identifier does not provide a reliable narrower distinction for the affected Qwen3.8 dense target. Safe configurations are unchanged.