docs: make DSv4 startup scripts safe with unset LD_PRELOAD - #279
Draft
matthewygf wants to merge 2 commits into
Draft
matthewygf wants to merge 2 commits into
matthewygf wants to merge 2 commits into
Conversation
matthewygf
requested a deployment
to
ci-hardware
August 27, 2026 16:13 — with
GitHub Actions
Waiting
matthewygf
requested a deployment
to
ci-hardware
August 27, 2026 16:13 — with
GitHub Actions
Waiting
matthewygf
requested a deployment
to
ci-hardware
August 27, 2026 16:13 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The DSv4 guides start their launch scripts with
set -euo pipefail, then expand$LD_PRELOADdirectly:On a host/container where
LD_PRELOADis unset, Bash exits withLD_PRELOAD: unbound variablebefore the LMCache controller or vLLM server starts. The pattern appears in the new cross-node P2P guide and both launch examples in the existing DSv4 guide.Fix
Use Bash's conditional expansion in all three snippets so jemalloc is set when the variable is absent and any existing preload list is preserved when present.
Validation
bash -uproduces exactly the jemalloc path./existing.soafter jemalloc.LD_PRELOAD=...:$LD_PRELOADsnippet remains.git diff --checkpasses.Risk
Documentation-only, three-line shell correction. It does not change runtime code or the intended jemalloc preload order.