Add MoVA inference and MP2 parity support - #48
Draft
akhauriyash wants to merge 5 commits into
Draft
Conversation
Serve the 36B MoVA checkpoint with packed Q/K/gate projections, output-sharded routed values, native router and norm semantics, ordinary RadixAttention caching, and live-update mappings. Reuse the fused-MoE first GEMM behind a compile-safe custom-op boundary and preserve the legacy K2 path.
Transformers 5 materializes a null rope_scaling field as an explicit default-RoPE dictionary. Treat that normalized representation as unscaled while retaining the fail-fast guard for actual scaling modes.
xLLM applies sigmoid, correction bias, expert selection, and top-k normalization in FP32 after the BF16 router projection. Match that contract in the native fallback so near-boundary routes do not change during serving.
The remote-instance seed path re-imported get_local_ip_auto from the utils package root after that API moved to utils.network. This caused every TP scheduler to fail before Mooncake initialization. Use the existing canonical module-level import and cover the transfer-engine and bootstrap contracts.
Preserve legacy router behavior when source topology is absent. For explicit MP1 or MP2 provenance, reproduce native BF16 local GEMM rounding and FP32 logits at both FFN and value routers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack dependencies
This is the SGLang side of the internal MoVA RL stack and is reviewed together with:
The validated training recipe must use
--no-rope-fusionfor MoVA. The pinned Megatron fused packed-THD RoPE path does not preserverotary_interleaved=True, causing trainer/rollout policy mismatch. Keep fusion disabled until the permanent Megatron fix passes end-to-end parity.Validation
198d611c005b789879ac73732e67d0d55d6362fdDraft for internal review. No merge requested.