Correct xLLM 375B rotary base - #77
Merged
Merged
Conversation
Collaborator
|
@nightlessbaron we should include the "why" of PRs more than the what. The what can be inferred from the code changes. The why is forgotten context that doesn't scale across individuals. |
Author
|
So this one is because we are aligning the rope setting with the mid training settings, they were incorrectly set before this which resulted in garbled outputs |
nightlessbaron
marked this pull request as ready for review
August 21, 2026 17:31
nightlessbaron
force-pushed
the
agent/xllm-375b-rotary-base
branch
from
August 21, 2026 17:32
d4068f5 to
3eb5f13
Compare
flukeskywalker
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
500000to10000000aligning the rope setting with the mid training settings, they were incorrectly set before this which resulted in garbled outputs