Fix Megatron checkpoint save and resume state - #70
Merged
Conversation
nightlessbaron
marked this pull request as ready for review
August 21, 2026 22:28
nightlessbaron
force-pushed
the
agent/checkpoint-resume-correctness
branch
from
August 21, 2026 22:28
3471303 to
f3b1193
Compare
odp
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
preprocess_common_state_dicthook when saving non-LoRA checkpoints.--no-load-optim, where scheduler state is intentionally not restored.Why
A normal resume already restores scheduler state in
load_checkpoint; stepping it again double-counts completed iterations. Checkpoint saves also need Megatron's common-state preprocessing to produce the expected distributed checkpoint state.Validation
4 passed.py_compile: passed.git diff --check: passed.Related Megatron optimizer-state fix: LLM360/Megatron-LM#6.