Collection of multiple smaller issues - #62
Draft
dominikgeissler wants to merge 50 commits into
Draft
Conversation
Equality checks for two loop free programs
dominikgeissler
marked this pull request as ready for review
March 6, 2025 14:14
dominikgeissler
changed the title
dominikgeissler
marked this pull request as draft
March 6, 2025 14:24
dominikgeissler
marked this pull request as ready for review
March 9, 2025 13:30
dominikgeissler
changed the title
LKlinke
reviewed
Mar 10, 2025
LKlinke
reviewed
Mar 10, 2025
LKlinke
reviewed
Mar 10, 2025
LKlinke
reviewed
Mar 10, 2025
Collaborator
Author
There was a problem hiding this comment.
i dont know, this comment was there before I started working here, but I will try it out
Collaborator
Author
There was a problem hiding this comment.
I executed it with the following command
python prodigy/cli.py --engine ginac main pgfexamples/inference/loopy/skip_random_walk.pgcl
followed by a fixed iteration and it worked fine, im not sure if and where an issue exists
LKlinke
reviewed
Mar 10, 2025
LKlinke
reviewed
Mar 10, 2025
LKlinke
reviewed
Mar 10, 2025
LKlinke
reviewed
Mar 10, 2025
| jinja2 = "3.1.4" | ||
| rope = "^0.17.0" | ||
| pytest-cov = "^2.9.0" | ||
| pytest-ordering = "^0.6" |
Owner
There was a problem hiding this comment.
this should not be necessary. We must investigate the issue related to this.
LKlinke
reviewed
Mar 10, 2025
LKlinke
reviewed
Mar 10, 2025
LKlinke
reviewed
Mar 10, 2025
LKlinke
requested changes
Mar 10, 2025
LKlinke
left a comment
LKlinke
left a comment
Owner
There was a problem hiding this comment.
Please see individual comments.
dominikgeissler
marked this pull request as draft
March 10, 2025 13:04
…os, adjusted readme and tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
see #56 #57 #60 #61 #65
compile_pgcldoesnt like boolean type variables #63