Issue 10 composer performance - #1149
Open
dereck-symmetry wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Previous (current) composer does the composition of each json fragment as it comes back. This means that the time grows on a quadratic. Specifically,
compose_json_with_fragment_list(components/lif/composer/core.py) loops over fragments and callscompose_json_with_single_fragmentfor each one. That function doesjson.loads(lif_record_json)thenjson.dumps(...)— i.e. a full serialization round-trip ofthe entire (growing) record per fragment.
Fix - compose directly on the dict, one parse / one model-dump at the boundary, zero intermediate
JSON. The public API is unchanged — all four functions keep their signatures and return types.
Closes #10
Type of Change
to not work as expected)
Project Area(s) Affected
Checklist
uv run ruff check)uv run ruff format)uv run ty check)Testing
Additional Notes
This change is deceptively small. I worked with Claude until we were able to get the least invasive procedure completed. WE MUST DO EXTENSIVELY end-to-end testing when this change is rolled into main. There shouldn't be any side effects, and I have tested extensively manually and with automated tools.
We should have LLM do additional testing and code verification on this small change after roll into main. There is, though, no suspicions that this will in any way fail.