feat(discord): delegate concurrent questions and preserve async routes - #1
Draft
Callanplays wants to merge 4 commits into
Draft
Callanplays wants to merge 4 commits into
Callanplays wants to merge 4 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
delegation.max_concurrent_children: unlimitedand renders that setting clearly in agent prompts and the TUI.processes.json, including gateway restart recovery, so external waiters such aspaseo wait <agent-id> --jsonwake the session that actually launched them instead of whichever conversation is current later.Why
Discord users commonly send a second, unrelated question while Hermes is still working. The previous busy-session modes either changed the active request, interrupted it, or delayed the new question. Native delegation lets both requests progress independently without creating a user-visible Discord fork/thread.
External agents such as Paseo also outlive the initiating Hermes turn. Their completion watcher therefore needs both the Discord lane and the exact durable Hermes session to return safely under concurrent conversations and after gateway restarts.
Validation
230 passedacross focused gateway busy-routing, completion delivery, background watcher, session-context, restart-drain, authorization, delegation, process-registry, and agent-guardrail tests.git diff --checkpassed.