Repository navigation
Fix MMR-Bench data integrity and optional joint input splitting - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix production MMR-Bench V1 loader issues found during the full-7 reproduction, without changing router algorithms or metrics.
complete-models: on the audited release, exclude GPT-5-nano (missing 3,040 MathVision observations), keep nine candidates in canonical order and all 10,370 queries. No missing-cell imputation or query dropping. Stricterrorpolicy is available and is the fallback for programmatic configs without a policy.model_i_response, retainingmodel_i_predictionas an identical backward-compatible alias. This allows EA-RAM to train its ex-post evaluator instead of silently skipping response-dependent training.joint-groupedin-domain splitting using transitive components of identical decoded RGB images OR whitespace-normalized query text. The default remains the historicallegacyrow-random split, with an overlap warning.Protocol caveats
The corrected nine-model candidate pool is not the historical ten-model evaluation. Joint grouping is optional and is not the untouched default protocol: fractions are approximate, grouping is not per-task stratified, and an entire task can fall in test. It prevents split input overlap, not external pretrained-model exposure.
Validation
git diff --checkpassed.Scope
Only the loader, benchmark/example configs, documentation and regression tests are included. No experiment runners, cache machinery, datasets, results, weights, NIRT gateway changes, credentials or machine-specific paths are committed.