Repository navigation
Rough pass at an architectural, journal-style look - #19
Open
loganfinney27 wants to merge 305 commits into
Open
loganfinney27 wants to merge 305 commits into
loganfinney27 wants to merge 305 commits into
Conversation
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
|
Review these changes at https://app.gitnotebooks.com/LAF-US/loganfinney/pull/19 |
|
The files' contents are under analysis for test generation. |
|
LGTM 🤖 Reviewed by codereviewbot.ai - Catch bugs before your team does. |
|
Your 14-day trial has expired! You have already exhausted your 14th day trial period. Please upgrade your subscription to continue new analysis. Upgrade by visiting: View Dashboard |
Reviewer's GuideThis PR replaces the previous soft, elevated UI with a ruled, journal-style system: text-based theme controls and typographic masthead, numbered sections, ledger layouts, bordered cells, responsive resume rows, and print-inspired footer/page framing, while retaining the existing palette, themes, frosted header, and hero treatment. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage | ✅ Passed | Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (3 skipped: 3 … |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately summarizes the main changes: a journal-style redesign across the site and a résumé page rewrite. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
✅ Precogs scan complete — No security issues foundCommit
✅ Passed checks (3)
💬 Precogs.ai · Detect. Fix. Merge. |
![inspect-review[bot]](https://avatars.githubusercontent.com/in/3177512?s=60&v=4){kind=small}
There was a problem hiding this comment.
inspect review
Triage: 65 entities analyzed | 0 critical, 0 high, 61 medium, 4 low
Verdict: standard_review
Findings (0)
Reviewed by inspect | Entity-level triage found 0 high-risk changes
🤖 CodeLens AI Review |
PR Analysis Summary
📧 Email-friendly summaryRisk: 🔴 High Risk | Complexity: 🟡 5.5/10 | Files: 5 Change Metrics
Risk factors:
Classification
Files by Type
💡 Recommendations
Analyzed by Woden Tagger • Automated PR insights for better code reviews
💡 Want enhanced Github Projects/Notes and to turn Issues into a Service Desk? Check out Woden Desk on the GitHub Marketplace |
🔴 SEO Review - 27 issues introduced by this PR8 deploy-blocking issues were introduced here - fix before this ships. 🔴 Critical (8) - fix before deploy
🟡 Warnings (8) · 🔵 Info (11) - expand to review🟡 Warnings (8)
🔵 Info (11)
✅ 542 checks passed
|
aislop skipped this PRThis workspace does not have an active paid scanaislop plan. Choose a plan to resume hosted scans and PR gates: This comment appears once per PR. Further pushes will be skipped silently until the workspace has paid access. |
QWED Security Verification Report49 files scanned | 0 blocked | 2 warnings | 0 info | 0 suppressed | 48 verified Advisory Warnings
Engines
Verified Files
Verified by QWED — deterministic security verification. No LLM used. Verification Context v1.0{
"spec_version": "1.0",
"object": {
"formal_statement": "LAF-US/loganfinney@0e2cce53 (PR #19) is safe to merge"
},
"context": {
"interpretation": {
"theory": "deterministic security verification",
"logic": "evidence-context-policy pipeline"
},
"proof": {
"verifier": "QWED Security",
"verifier_version": "qwed-security-ruleset/12",
"configuration": {
"repo": "LAF-US/loganfinney",
"head_sha": "0e2cce53e1f6482e17be5b88e0ea3c934155d772",
"files_scanned": 49
},
"theory_scope": "PR security scan against QWED deterministic rule set",
"trusted_dependencies": [
"qwed-security"
],
"outcome_treatment": "unknown/timeout/error resolve to UNVERIFIABLE or BLOCKED"
},
"evidence": {
"evidence": {
"status": "UNVERIFIABLE",
"agent_message": "PR requires review: 4 advisory finding(s).",
"developer_fields": {
"total_warnings": 4,
"advisory_checks": []
},
"is_authoritative": false,
"scan_evidence": {
"repo": "LAF-US/loganfinney",
"head_sha": "0e2cce53e1f6482e17be5b88e0ea3c934155d772",
"pr_number": 19,
"files_scanned": 49,
"engine_results": 142,
"conclusion": "neutral",
"rule_set": "qwed-security-ruleset/12",
"engines": [
"ci_scan",
"codeguard",
"dependency_scan",
"entropy_scan",
"js_patterns",
"lockfile_scan",
"pattern_scan",
"python_ast",
"python_deep_ast",
"secret_scan",
"taint_analysis",
"verification_integrity"
]
},
"repo": "LAF-US/loganfinney",
"head_sha": "0e2cce53e1f6482e17be5b88e0ea3c934155d772",
"files_scanned": 49
},
"proof_ref": null
},
"decision": {
"admission": "DENY"
}
},
"verdict": "UNVERIFIABLE"
} |
![gitginie[bot]](https://avatars.githubusercontent.com/in/712912?s=60&v=4){kind=small}
There was a problem hiding this comment.
@loganfinney27
Thank you for your contribution to this repository! We appreciate your effort in opening pull request.
Happy coding!
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
|
LGTM 🤖 Reviewed by codereviewbot.ai - Catch bugs before your team does. |
✅ Precogs scan complete — No security issues foundCommit
✅ Passed checks (3)
💬 Precogs.ai · Detect. Fix. Merge. |
PR Analysis Summary
📧 Email-friendly summaryRisk: 🔴 High Risk | Complexity: 🟡 5.5/10 | Files: 5 Change Metrics
Risk factors:
Classification
Files by Type
💡 Recommendations
Analyzed by Woden Tagger • Automated PR insights for better code reviews
💡 Want enhanced Github Projects/Notes and to turn Issues into a Service Desk? Check out Woden Desk on the GitHub Marketplace |
🤖 CodeLens AI Review |
There was a problem hiding this comment.
inspect review
Triage: 65 entities analyzed | 0 critical, 0 high, 61 medium, 4 low
Verdict: standard_review
Findings (0)
Reviewed by inspect | Entity-level triage found 0 high-risk changes
The copy is RenderCV 2.8 plus the IMDb fix and the 20 new social networks, pinned to a full commit ID. Both jobs that render cv.yaml try the regular RenderCV first and swap in the copy only if it fails, so the site goes back to the regular one on its own once a release Dependabot proposes can read cv.yaml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014e9aGs3SxNfCer3Nmunb6e
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
🤖 CodeAnt AI — Review Status
|
PR Analysis Summary
📧 Email-friendly summaryRisk: 🔴 High Risk | Complexity: 🔴 10/10 | Files: 29 Change Metrics
Risk factors:
Classification
Files by Type
+5 more file types 💡 Recommendations
🚫 Files Excluded from Analysis1 file(s) excluded (1,227 lines) - generated, minified, or binary files that don't need review
Analyzed by Woden Tagger • Automated PR insights for better code reviews
💡 Want enhanced Github Projects/Notes and to turn Issues into a Service Desk? Check out Woden Desk on the GitHub Marketplace |
✅ Precogs scan complete — No security issues foundCommit
✅ Passed checks (3)
💬 Precogs.ai · Detect. Fix. Merge. |
🛡️ Zaxion Policy Status: ⏳ PENDINGAnalyzing Risk...
Visit the Full Report for detailed metrics, findings, and interactive remediation. |
There was a problem hiding this comment.
inspect review
Triage: 174 entities analyzed | 0 critical, 0 high, 73 medium, 101 low
Verdict: standard_review
Findings (0)
Reviewed by inspect | Entity-level triage found 0 high-risk changes
🤖 CodeLens AI Review |
![seoguard[bot]](https://avatars.githubusercontent.com/in/3556014?s=60&v=4){kind=small}
| @@ -0,0 +1,14 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
| <head> | |||
There was a problem hiding this comment.
Missing viewport meta tag - Add inside
Suggested change
| <head> | |
| <head> | |
| <meta name="viewport" content="width=device-width, initial-scale=1" /> |
| @@ -0,0 +1,14 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
| <head> | |||
There was a problem hiding this comment.
Missing charset declaration - Add as the first tag inside
Suggested change
| <head> | |
| <head> | |
| <meta charset="utf-8" /> |
|
Insufficient balance to process this code review. Please add funds or upgrade your plan in billing. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| cv = Path(__file__).resolve().parents[2] / "cv.yaml" | ||
| with tempfile.TemporaryDirectory() as folder: | ||
| check = subprocess.run( |
| else: | ||
| print(f"::notice::The regular RenderCV ({version('rendercv')}) can't read cv.yaml, so the build uses LAF-US's copy") | ||
| print(check.stdout, check.stderr, sep="\n") | ||
| subprocess.run([sys.executable, "-m", "pip", "install", "--no-deps", "--force-reinstall", f"rendercv @ {COPY}"], check=True) |
🛡️ Zaxion Policy Status: 🔴 BLOCKGateway Blocked
Visit the Full Report for detailed metrics, findings, and interactive remediation. |
Sieve Security Scan ✅No likely vulnerabilities found in changed files. 0 real · 0 suppressed · 0 FP · 0 total |
🤖 CodeAnt AI — Review Status
|
![mergestorm-vortex[bot]](https://avatars.githubusercontent.com/in/3924858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review progress ██████████ 93/93 files
Request changes — found 3 issue(s) at 267359e.
Actionable comments posted: 3
🤖 Prompt for AI agents
Verify each finding against current code. Fix only still-valid concrete bugs, skip the
rest with a brief reason, keep changes minimal, and validate. Skip Decision required,
policy forks, and "consider X" alternatives. Do not add new features, refactors, or
architecture beyond the fix; prefer the smallest diff.
Findings to address:
1. In `@.github/workflows/jekyll-gh-pages.yml` (line 108, Important):
`rendercv render cv.yaml` publishes the CV with profiles under `cv.social_networks`, but `_includes/head.html`, `_includes/seo.html`, and `llms.txt` still read `cv.custom_connections`. As a result, the deployed page omits the `rel="me"` links (including Mastodon verification), JSON-LD `sameAs`, and the profile list in `llms.txt`, even though those profiles appear in the rendered CV.
Additional findings outside changed lines:
1. In `@index.html` (line 33, Blocker):
`{% include rendercv.html %}` renders the CV generated from `cv.yaml`, and that file still holds ...
`{% include rendercv.html %}` renders the CV generated from `cv.yaml`, and that file still holds RenderCV's sample content. Verified in `cv.yaml`: `email: john.doe@email.com`, `website: https://rendercv.com/`, `headline: Documentary Journalist`, a 'Welcome to RenderCV' section, and an education entry for a Princeton PhD. This feeds the public CV section, the PDF, the vCard, and the header/footer name and headline via `site.data.cv.cv`. The result is that the live site presents invented credentials for a real reporter, which contradicts the PR's claim that the R\u00e9sum\u00e9 was rewritten from public sources. Replace `cv.yaml` with Logan's real content before merge, or keep the CV include out of the published build until it is ready.
2. In `@logan.vcf` (line 6, Blocker):
vCard and site identity read from RenderCV sample cv.yaml
`{% include vcard-line.txt property="FN:" value=site.data.cv.cv.name %}` (and the N:/TITLE: lines) pull from `cv.yaml`, which at this head still contains RenderCV sample content: `Princeton University` PhD, `Boğaziçi University`, `Welcome to RenderCV` section, `email: john.doe@email.com`, `website: https://rendercv.com/`, and `*John Doe*` highlights. `index.html` renders that same file into the visible CV via `rendercv.html`, so the published home page advertises fabricated credentials. Replace `cv.yaml` with Logan's actual CV data before merge.
Still open from earlier reviews (2) — the lines they point at have not changed:
- 🔴 Blocker ·
{% include rendercv.html %}renders the CV generated fromcv.yaml, and that file still holds ... ·index.htmlline 33 · from6b070d0
{% include rendercv.html %}renders the CV generated fromcv.yaml, and that file still holds RenderCV's sample content. Verified incv.yaml:email: john.doe@email.com,website: https://rendercv.com/,headline: Documentary Journalist, a 'Welcome to RenderCV' section, and an education entry for a Princeton PhD. This feeds the public CV section, the PDF, the vCard, and the header/footer name and headline viasite.data.cv.cv. The result is that the live site presents invented credentials for a real reporter, which contradicts the PR's claim that the R\u00e9sum\u00e9 was rewritten from public sources. Replacecv.yamlwith Logan's real content before merge, or keep the CV include out of the published build until it is ready. - 🔴 Blocker · vCard and site identity read from RenderCV sample cv.yaml ·
logan.vcfline 6 · from6b070d0
{% include vcard-line.txt property="FN:" value=site.data.cv.cv.name %}(and the N:/TITLE: lines) pull fromcv.yaml, which at this head still contains RenderCV sample content:Princeton UniversityPhD,Boğaziçi University,Welcome to RenderCVsection,email: john.doe@email.com,website: https://rendercv.com/, and*John Doe*highlights.index.htmlrenders that same file into the visible CV viarendercv.html, so the published home page advertises fabricated credentials. Replacecv.yamlwith Logan's actual CV data before merge.
| run: | | ||
| options=$(python3 .github/scripts/rendercv-options.py) | ||
| mapfile -t options <<< "$options" | ||
| rendercv render cv.yaml "${options[@]}" -nopng -o "$RUNNER_TEMP/rendercv" |
There was a problem hiding this comment.
CV profiles are not propagated to site metadata
rendercv render cv.yaml publishes the CV with profiles under cv.social_networks, but _includes/head.html, _includes/seo.html, and llms.txt still read cv.custom_connections. As a result, the deployed page omits the rel="me" links (including Mastodon verification), JSON-LD sameAs, and the profile list in llms.txt, even though those profiles appear in the rendered CV.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid concrete bugs, skip the
rest with a brief reason, keep changes minimal, and validate. Skip Decision required,
policy forks, and "consider X" alternatives. Do not add new features, refactors, or
architecture beyond the fix; prefer the smallest diff.
In `@.github/workflows/jekyll-gh-pages.yml` (line 108, Important):
`rendercv render cv.yaml` publishes the CV with profiles under `cv.social_networks`, but `_includes/head.html`, `_includes/seo.html`, and `llms.txt` still read `cv.custom_connections`. As a result, the deployed page omits the `rel="me"` links (including Mastodon verification), JSON-LD `sameAs`, and the profile list in `llms.txt`, even though those profiles appear in the rendered CV.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/jekyll-gh-pages.yml">
<violation number="1" location=".github/workflows/jekyll-gh-pages.yml:57">
P2: This step installs an unreleased RenderCV fork from a git URL into the job that builds the artifact deployed to production, and it bypasses the pip cooldown this PR's own threat model relies on. Pinning the commit SHA limits tampering, but it leaves the fork's code running unreviewed in the publish path. Consider vendoring the two needed changes or gating the fallback on a reviewed artifact. The fallback also fires on any render failure, not only the cv.yaml read errors it targets.</violation>
<violation number="2" location=".github/workflows/jekyll-gh-pages.yml:58">
P2: Update the site metadata consumers to read `cv.social_networks`; otherwise profiles accepted by this RenderCV fallback are omitted from `rel="me"`, JSON-LD `sameAs`, and `llms.txt`.</violation>
</file>
Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack
View guided diff | Turn on auto-fix | Re-trigger cubic
| python-version: "3.13" | ||
| - name: Install RenderCV (versions in .github/requirements.txt) | ||
| run: pip install -r .github/requirements.txt | ||
| - name: Use LAF-US's copy of RenderCV if the regular one can't read cv.yaml (.github/scripts/rendercv-copy.py) |
There was a problem hiding this comment.
P2: This step installs an unreleased RenderCV fork from a git URL into the job that builds the artifact deployed to production, and it bypasses the pip cooldown this PR's own threat model relies on. Pinning the commit SHA limits tampering, but it leaves the fork's code running unreviewed in the publish path. Consider vendoring the two needed changes or gating the fallback on a reviewed artifact. The fallback also fires on any render failure, not only the cv.yaml read errors it targets.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/jekyll-gh-pages.yml, line 57:
<comment>This step installs an unreleased RenderCV fork from a git URL into the job that builds the artifact deployed to production, and it bypasses the pip cooldown this PR's own threat model relies on. Pinning the commit SHA limits tampering, but it leaves the fork's code running unreviewed in the publish path. Consider vendoring the two needed changes or gating the fallback on a reviewed artifact. The fallback also fires on any render failure, not only the cv.yaml read errors it targets.</comment>
<file context>
@@ -54,6 +54,8 @@ jobs:
python-version: "3.13"
- name: Install RenderCV (versions in .github/requirements.txt)
run: pip install -r .github/requirements.txt
+ - name: Use LAF-US's copy of RenderCV if the regular one can't read cv.yaml (.github/scripts/rendercv-copy.py)
+ run: python3 .github/scripts/rendercv-copy.py
- name: Compare the CV as of the last successful run with the CV today
</file context>
| - name: Install RenderCV (versions in .github/requirements.txt) | ||
| run: pip install -r .github/requirements.txt | ||
| - name: Use LAF-US's copy of RenderCV if the regular one can't read cv.yaml (.github/scripts/rendercv-copy.py) | ||
| run: python3 .github/scripts/rendercv-copy.py |
There was a problem hiding this comment.
P2: Update the site metadata consumers to read cv.social_networks; otherwise profiles accepted by this RenderCV fallback are omitted from rel="me", JSON-LD sameAs, and llms.txt.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/jekyll-gh-pages.yml, line 58:
<comment>Update the site metadata consumers to read `cv.social_networks`; otherwise profiles accepted by this RenderCV fallback are omitted from `rel="me"`, JSON-LD `sameAs`, and `llms.txt`.</comment>
<file context>
@@ -54,6 +54,8 @@ jobs:
- name: Install RenderCV (versions in .github/requirements.txt)
run: pip install -r .github/requirements.txt
+ - name: Use LAF-US's copy of RenderCV if the regular one can't read cv.yaml (.github/scripts/rendercv-copy.py)
+ run: python3 .github/scripts/rendercv-copy.py
- name: Compare the CV as of the last successful run with the CV today
id: compare
</file context>
…ery package The swap now stands in only for RenderCV 2.8, the version LAF-US's copy is built on. Any other RenderCV that can't read cv.yaml fails the build instead of being quietly replaced, so a Dependabot pull request for a release that breaks the CV fails as it did before the swap existed. Installing the copy builds it from source; its build tool is now pinned (uv_build 0.10.12) instead of taking the newest in its range. Every pip install now takes only versions uploaded at least 7 days ago (PIP_UPLOADED_PRIOR_TO=P7D), the same wait Dependabot keeps, including the 27 packages that RenderCV and the others bring in and no file pins. pip 26.1 and newer follow that setting and older ones ignore it, so each job installs pip 26.2.1 first (.github/requirements-pip.txt, kept current by Dependabot). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014e9aGs3SxNfCer3Nmunb6e
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
🤖 CodeAnt AI — Review Status
|
✅ Precogs scan complete — No security issues foundCommit
✅ Passed checks (3)
💬 Precogs.ai · Detect. Fix. Merge. |
PR Analysis Summary
📧 Email-friendly summaryRisk: 🔴 High Risk | Complexity: 🔴 10/10 | Files: 29 Change Metrics
Risk factors:
Classification
Files by Type
+5 more file types 💡 Recommendations
🚫 Files Excluded from Analysis1 file(s) excluded (1,227 lines) - generated, minified, or binary files that don't need review
Analyzed by Woden Tagger • Automated PR insights for better code reviews
💡 Want enhanced Github Projects/Notes and to turn Issues into a Service Desk? Check out Woden Desk on the GitHub Marketplace |
There was a problem hiding this comment.
inspect review
Triage: 176 entities analyzed | 0 critical, 0 high, 73 medium, 103 low
Verdict: standard_review
Findings (0)
Reviewed by inspect | Entity-level triage found 0 high-risk changes
🤖 CodeLens AI Review |
| @@ -0,0 +1,14 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
| <head> | |||
There was a problem hiding this comment.
Missing viewport meta tag - Add inside
Suggested change
| <head> | |
| <head> | |
| <meta name="viewport" content="width=device-width, initial-scale=1" /> |
| @@ -0,0 +1,14 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
| <head> | |||
There was a problem hiding this comment.
Missing charset declaration - Add as the first tag inside
Suggested change
| <head> | |
| <head> | |
| <meta charset="utf-8" /> |
|
Insufficient balance to process this code review. Please add funds or upgrade your plan in billing. |
Sieve Security Scan ✅No likely vulnerabilities found in changed files. 0 real · 0 suppressed · 0 FP · 0 total |
🛡️ Zaxion Policy Status: ⏳ PENDINGAnalyzing Risk...
Visit the Full Report for detailed metrics, findings, and interactive remediation. |
🛡️ Zaxion Policy Status: 🔴 BLOCKGateway Blocked
Visit the Full Report for detailed metrics, findings, and interactive remediation. |
🤖 CodeAnt AI — Review Status
|
There was a problem hiding this comment.
Review progress ██████████ 94/94 files
Request changes — found 2 issue(s) outside changed lines at 0e2cce5.
Actionable comments posted: 2
🤖 Prompt for AI agents
Verify each finding against current code. Fix only still-valid concrete bugs, skip the
rest with a brief reason, keep changes minimal, and validate. Skip Decision required,
policy forks, and "consider X" alternatives. Do not add new features, refactors, or
architecture beyond the fix; prefer the smallest diff.
Findings to address:
1. In `@index.html` (line 33, Blocker):
`{% include rendercv.html %}` renders the CV generated from `cv.yaml`, and that file still holds ...
`{% include rendercv.html %}` renders the CV generated from `cv.yaml`, and that file still holds RenderCV's sample content. Verified in `cv.yaml`: `email: john.doe@email.com`, `website: https://rendercv.com/`, `headline: Documentary Journalist`, a 'Welcome to RenderCV' section, and an education entry for a Princeton PhD. This feeds the public CV section, the PDF, the vCard, and the header/footer name and headline via `site.data.cv.cv`. The result is that the live site presents invented credentials for a real reporter, which contradicts the PR's claim that the R\u00e9sum\u00e9 was rewritten from public sources. Replace `cv.yaml` with Logan's real content before merge, or keep the CV include out of the published build until it is ready.
2. In `@logan.vcf` (line 6, Blocker):
vCard and site identity read from RenderCV sample cv.yaml
`{% include vcard-line.txt property="FN:" value=site.data.cv.cv.name %}` (and the N:/TITLE: lines) pull from `cv.yaml`, which at this head still contains RenderCV sample content: `Princeton University` PhD, `Boğaziçi University`, `Welcome to RenderCV` section, `email: john.doe@email.com`, `website: https://rendercv.com/`, and `*John Doe*` highlights. `index.html` renders that same file into the visible CV via `rendercv.html`, so the published home page advertises fabricated credentials. Replace `cv.yaml` with Logan's actual CV data before merge.
Still open from earlier reviews (2) — the lines they point at have not changed:
- 🔴 Blocker ·
{% include rendercv.html %}renders the CV generated fromcv.yaml, and that file still holds ... ·index.htmlline 33 · from6b070d0
{% include rendercv.html %}renders the CV generated fromcv.yaml, and that file still holds RenderCV's sample content. Verified incv.yaml:email: john.doe@email.com,website: https://rendercv.com/,headline: Documentary Journalist, a 'Welcome to RenderCV' section, and an education entry for a Princeton PhD. This feeds the public CV section, the PDF, the vCard, and the header/footer name and headline viasite.data.cv.cv. The result is that the live site presents invented credentials for a real reporter, which contradicts the PR's claim that the R\u00e9sum\u00e9 was rewritten from public sources. Replacecv.yamlwith Logan's real content before merge, or keep the CV include out of the published build until it is ready. - 🔴 Blocker · vCard and site identity read from RenderCV sample cv.yaml ·
logan.vcfline 6 · from6b070d0
{% include vcard-line.txt property="FN:" value=site.data.cv.cv.name %}(and the N:/TITLE: lines) pull fromcv.yaml, which at this head still contains RenderCV sample content:Princeton UniversityPhD,Boğaziçi University,Welcome to RenderCVsection,email: john.doe@email.com,website: https://rendercv.com/, and*John Doe*highlights.index.htmlrenders that same file into the visible CV viarendercv.html, so the published home page advertises fabricated credentials. Replacecv.yamlwith Logan's actual CV data before merge.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
A redesign of the site as a ruled, print-style page on a 1.5rem graph-paper grid, plus a full rewrite of the Résumé.
Design
Home page
_includes/bio.html) that the Résumé also uses.tablist/tab/tabpanelmarkup, arrow-key and Home/End navigation, and tooltips on hover and focus. With scripts off, every panel shows.Résumé
Folio
Checks
Deferred to the next PR: Folio CV-style rewrite, pa11y-ci 5.0.0 upgrade and subdomains.
🤖 Generated with Claude Code
https://claude.ai/code/session_014e9aGs3SxNfCer3Nmunb6e
CodeAnt-AI Description
Redesign the site as a print-style home for the CV and portfolio
What Changed
Impact
✅ CV and portfolio together on one page✅ Theme choice remembered during the visit✅ CV printouts include web addresses for links💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.