Repository navigation
Feat: Randomize reminder messages - #21
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds randomized reminder text to the timer UI to address Issue #8 (“この時間はもう戻りません” を複数パターンでランダム表示).
Changes:
- Introduce a new reminder-message catalog + random picker utility.
- Update
NumaTimerto display a randomly selected reminder message instead of a fixed string.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/messages.ts | Adds reminder message variants and a function to pick one at random. |
| components/NumaTimer.tsx | Uses the new picker and renders the selected reminder message in the UI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
59
to
60
| const reminderMessage = useMemo(() => pickReminderMessage(), []) | ||
|
|
There was a problem hiding this comment.
reminderMessage is intended to be stable for the lifetime of the component, but useMemo is not a semantic guarantee (React may discard memoized values). Prefer useState with an initializer or useRef to compute the random message once per mount and keep it stable across renders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #8