Repository navigation
CI: attach release artifacts - #20
Conversation
|
これ実際に release しないとテストできないじゃん！ うぐぐぐぐ |
There was a problem hiding this comment.
Pull request overview
Adds CI support to attach the built extension zip as an asset to GitHub Releases, complementing the existing “main-latest” rolling prerelease flow.
Changes:
- Trigger workflow on
release.publishedevents. - Add a
publish-releasejob that downloads the build artifact, renames it to the versioned name, and uploads it to the corresponding GitHub Release.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uses: softprops/action-gh-release@v2 | ||
| with: | ||
| tag_name: ${{ github.event.release.tag_name }} | ||
| files: dist/${{ needs.build.outputs.zip_name }} |
There was a problem hiding this comment.
softprops/action-gh-release will error if an asset with the same name already exists on the release (e.g., when re-running this workflow). Consider setting overwrite_files: true (as done in publish-main-latest) or otherwise handling existing assets to make re-runs idempotent.
| files: dist/${{ needs.build.outputs.zip_name }} | |
| files: dist/${{ needs.build.outputs.zip_name }} | |
| overwrite_files: true |
| - name: Prepare release asset name | ||
| run: | | ||
| mv dist/chrome-mv3-prod.zip "dist/${{ needs.build.outputs.zip_name }}" |
There was a problem hiding this comment.
This job assumes the downloaded artifact will contain a file named chrome-mv3-prod.zip (and then renames it). To reduce coupling to the internal filename inside the artifact, consider renaming/copying the packaged zip to ${{ steps.meta.outputs.zip_name }} in the build job before uploading, so downstream jobs can consume the artifact without hardcoding chrome-mv3-prod.zip.
codex を信じてはいけない