Skip to content

fix(windows): stabilize installer and update handoff smoke - #1260

Merged
XingYu-Zhong merged 1 commit into
KunAgent:developfrom
SunwardL:codex/fix-windows-installer-smoke-timeout
Sep 2, 2026
Merged

fix(windows): stabilize installer and update handoff smoke#1260
XingYu-Zhong merged 1 commit into
KunAgent:developfrom
SunwardL:codex/fix-windows-installer-smoke-timeout

Conversation

@SunwardL

@SunwardL SunwardL commented Sep 2, 2026

Copy link
Copy Markdown

Summary

  • give the complete Windows installer migration step 120 minutes and its enclosing job 180 minutes in PR, daily, and release workflows
  • keep each installer and copied-uninstaller process bounded to 600 seconds with explicit PID/scenario failures
  • keep restored manual-upgrade user files at their actual source until the external-drive fixture is staged
  • assert all-users outer/inner installer evidence on the diagnostic action that records it
  • normalize Win32 CIM process creation time to ISO-8601 before packaged handoff identity verification

Why

Follow-up to #1257. Successive Windows runs exposed independent assumptions in the smoke path: the full migration matrix exceeds 60 minutes, individual clean installs can exceed 300 seconds, rollback restores unknown files to the legacy source, all-users source/UAC evidence is emitted by FallbackCleanup, and Windows PowerShell 5.1 serializes CIM CreationDate as /Date(...)/, which Date.parse() cannot verify.

The workflow remains bounded at every layer. The identity fix also keeps the fail-closed PID-generation checks intact; it only makes the PowerShell timestamp transport unambiguous.

Tests

  • npx vitest run src/main/windows-installer-manual-upgrade-smoke.test.ts src/main/windows-installer-migration.test.ts (39 passed)
  • npx vitest run src/main/kun-process.ports.test.ts src/main/kun-process-identity.test.ts (20 passed)
  • npm run typecheck
  • ESLint on all changed TypeScript files
  • Windows PowerShell 5.1 parser validation for changed smoke scripts
  • parsed all three updated workflows and verified Windows budgets: job 180, migration 120, handoff 20
  • npm run check:file-lines
  • git diff --check
  • configured Windows win-unpacked rebuild
  • npm run smoke:packaged-update-handoff -- --resources dist/win-unpacked/resources (4 update paths and 2 fail-closed owner cases passed)
  • GitHub run 33617817308 reached the penultimate long migration scenario before the old 60-minute step limit terminated it

@SunwardL
SunwardL force-pushed the codex/fix-windows-installer-smoke-timeout branch 3 times, most recently from 170460b to 080e1f7 Compare September 2, 2026 10:07
@SunwardL SunwardL changed the title fix(ci): allow slow Windows installer smoke fix(windows): stabilize installer and update handoff smoke Sep 2, 2026
@SunwardL
SunwardL force-pushed the codex/fix-windows-installer-smoke-timeout branch from 080e1f7 to d69900e Compare September 2, 2026 11:57
@XingYu-Zhong
XingYu-Zhong merged commit 53fc235 into KunAgent:develop Sep 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants