Label multi-class classifier mode as a preview feature#388
Open
gbeane wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Marks the multi-class classifier mode as a preview feature in the settings UI, while ensuring the underlying persisted value remains the ClassifierMode enum (not the display label).
Changes:
- Relabeled the multi-class option to “Multi-class (Preview)” and added preview/beta caveats to the help text.
- Ensured the mode combo box stores the
ClassifierModeenum as item data (label is display-only). - Added a UI test that guards enum-based round-tripping independent of the label text.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/jabs/ui/settings_dialog/classifier_mode_settings_group.py |
Updates the multi-class label and adds preview-feature messaging in the help documentation while keeping enum-backed combo data. |
tests/ui/test_settings_dialog.py |
Adds a regression test to confirm set_values/get_values round-trip the ClassifierMode value (not the label). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Marks multi-class classifier mode as a preview/beta feature in the UI, the one hard blocker for merging multi-class into
mainas a preview while remaining work continues in follow-up releases.Changes
classifier_mode_settings_group.py:"Multi-class"→"Multi-class (Preview)".ClassifierModeenum as item data (the string is display-only), so the relabel does not affect persistence —get_values/set_valuesstill bind to the enum.Tests
test_classifier_mode_group_roundtrips_enum_not_label, confirming set/get round-trip on theClassifierModevalue independent of the display label (guards against the relabel breaking data binding).3 settings-dialog tests pass; ruff clean.
Notes
Default mode remains
BINARY; binary projects are unaffected. This is part of the multi-class beta-readiness work — the section 10 latent-bug fixes (PRs #385, #386, andfix/multiclass-save-predictions-shape) should also land onfeature/multiclassbefore it is merged tomain.