Repository navigation
feat(terminal): 添加逐窗格命令输出采集与本机会话映射 - #308
Open
galact-byte wants to merge 9 commits into
Open
galact-byte wants to merge 9 commits into
galact-byte wants to merge 9 commits into
Conversation
galact-byte
force-pushed
the
feat/recent-output-pane-capture
branch
from
October 2, 2026 14:11
81110ec to
fa8643f
Compare
Adapt pane output capture and local references to the current upstream APIs. Preserve shutdown persistence, instance isolation, and send-time Enter encoding. Gate GPUI capture tests on gpui-test-support.
Merge upstream b03f994. Preserve local output references and upstream recovery test registration.
galact-byte
marked this pull request as ready for review
November 20, 2026 12:12
Kuddev
requested changes
Nov 21, 2026
Kuddev
left a comment
Owner
There was a problem hiding this comment.
在 3967b029 复现了启动时丢失阅读位置的问题。归档仍在后台读取时,先用滚动条往回翻 7 行。归档到达后,首行从 startup line 6 跳回 startup line 13。现有手动滚动测试覆盖的是先恢复、再滚动的顺序。macOS 复现,18 项通过、1 项失败
请保留用户已选中的视口,同时把归档插入滚动历史。我把修复和回归用例整理成了可直接 cherry-pick 的提交。按相同用例复测,手动选择的首行保持不变,旧命令也仍然可读,19 项全部通过。修复 46f6436f · 复测
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
用户结果
为 #160 接入逐窗格最近命令输出采集、静态恢复和本机会话引用。设置 UI、窗口保存及启动恢复由 #309 接入。
设计边界
TerminalView仅在命令确认后开始记录,保留空输入、运行中程序和备用屏保护;备用屏活动时读取主屏。本次审查修复
接入维护者提供的
46f6436ff58ba89662bc3a23517703b0621ac4dd,保留原作者。当前提交为149469f72fd9bd9e22ff656978a08726df6860e5,修复后的源码树与该提交一致。归档在后台读取期间,用户通过滚动条或滚轮选择了阅读位置,归档到达时不再重设该视口;旧输出仍插入滚动历史。未手动滚动时保留原有展示行为。新增“先滚动、后恢复”的回归用例。
验证结果与边界
startup line 6跳到startup line 13;应用修复后最近输出测试 19 项全部通过。/d、隔离配置、未插桩的产品二进制。先滚轮选择startup line 73,再等待后台归档到达,首行保持 73,归档中的旧输出仍可读。滚动条路径由新增 GPUI 回归用例覆盖,本轮未另做原生滚动条拖拽实测。independently_loaded_symlink_aliases_share_the_same_writer_permit:两版均因符号链接权限不足失败,Windows 错误 1314。mobile_three_states_and_manual_copy_use_the_rendered_controls:两版均失败于控件宽度断言。command_palette_labels_follow_the_active_language:两版均得到中文标签,而用例期望英文。git_completion_real_repository_reaches_all_modes_and_preserves_quoted_edits:完整套件中失败,两版单独复跑均通过,完整套件中的失败根因尚未核定。必须确认