Repository navigation
feat(updater): support custom GitHub release sources #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WilliamWang1721
wants to merge
84
commits into
Kuddev:main
Choose a base branch
from
WilliamWang1721:feat/custom-update-source-minimal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+540
−58
Open
Changes from all commits
Commits
Show all changes
84 commits
Select commit
Hold shift + click to select a range
0f4dd63
feat(updater): support custom GitHub release sources
WilliamWang1721 5b3b8fe
fix(updater): invalidate stale checks when the source changes
WilliamWang1721 dce8742
Merge branch 'main' into feat/custom-update-source-minimal
WilliamWang1721 ff9f793
fix(ci): satisfy updater formatting and architecture checks
WilliamWang1721 a57f49f
Merge upstream main into feat/custom-update-source-minimal
WilliamWang1721 82c735d
Merge upstream main into feat/custom-update-source-minimal
WilliamWang1721 5d0a9d0
Merge upstream main into feat/custom-update-source-minimal
WilliamWang1721 a2e45a7
Merge upstream main into feat/custom-update-source-minimal
WilliamWang1721 b966eae
Merge branch 'main' into feat/custom-update-source-minimal
WilliamWang1721 4632f1f
Merge branch 'main' into feat/custom-update-source-minimal
WilliamWang1721 00c206e
Merge upstream main into feat/custom-update-source-minimal
WilliamWang1721 f7a5d88
Merge upstream main
WilliamWang1721 4f4caf8
Merge upstream main into feat/custom-update-source-minimal
WilliamWang1721 b15c57b
Merge upstream main into feat/custom-update-source-minimal
WilliamWang1721 6b3e45c
Merge upstream main into feat/custom-update-source-minimal
WilliamWang1721 9826c3f
fix(updater): invalidate stale source checks
WilliamWang1721 9a415b8
style(updater): format update event
WilliamWang1721 eb61f69
fix(i18n): localize release source validation
WilliamWang1721 f56114d
style(updater): format source error mapping
WilliamWang1721 4bb0810
fix(updater): resolve source validation language
WilliamWang1721 9d0988f
Merge remote-tracking branch 'origin/main' into feat/custom-update-so…
WilliamWang1721 7c1ec8d
fix(i18n): localize update source mismatch
WilliamWang1721 4e47c5c
Merge remote-tracking branch 'origin/main' into feat/custom-update-so…
WilliamWang1721 15d9197
Merge current main and preserve managed update distribution behavior
WilliamWang1721 dbfcce9
test(updater): exercise source input, save validation and persisted r…
WilliamWang1721 611e13e
Merge latest upstream main for strict PR validation
WilliamWang1721 c6ab9d2
Merge latest upstream main while preserving reviewed feature fixes
WilliamWang1721 45e8ce4
Merge current upstream mobile changes without expanding feature scope
WilliamWang1721 edb1880
Merge upstream 2.1.0 and theme improvements while retaining verified …
WilliamWang1721 c2a3ba3
Merge upstream main into feat/custom-update-source-minimal
WilliamWang1721 f27044c
Merge current upstream main, preserving reviewed desktop feature beha…
WilliamWang1721 2b7d5aa
Merge upstream main into feat/custom-update-source-minimal
WilliamWang1721 7baae46
Merge upstream main into feat/custom-update-source-minimal
WilliamWang1721 3b54dbc
Merge upstream main into PR #294
WilliamWang1721 c62a111
Merge upstream main into PR #294
WilliamWang1721 08bbe9a
Merge upstream main into PR #294
WilliamWang1721 6b3952d
Merge upstream main into PR #294
WilliamWang1721 bfbc203
Merge upstream main into feat/custom-update-source-minimal
WilliamWang1721 5a757fc
Merge upstream main into feat/custom-update-source-minimal
WilliamWang1721 5bc090d
Merge main into feat/custom-update-source-minimal
WilliamWang1721 bf3b458
Merge main into feat/custom-update-source-minimal
claude 0115f71
Merge main into feat/custom-update-source-minimal
WilliamWang1721 598f174
Merge main into feat/custom-update-source-minimal
WilliamWang1721 8398152
Merge main into feat/custom-update-source-minimal
WilliamWang1721 50c5e4c
Merge main into feat/custom-update-source-minimal
WilliamWang1721 c938333
Merge main into feat/custom-update-source-minimal
WilliamWang1721 9495ede
Merge main into feat/custom-update-source-minimal
WilliamWang1721 53b63fc
Merge main into feat/custom-update-source-minimal
WilliamWang1721 3fedc5d
Merge main into feat/custom-update-source-minimal
WilliamWang1721 874c8ab
Merge main into feat/custom-update-source-minimal
WilliamWang1721 cbb4e5b
Merge main into feat/custom-update-source-minimal
WilliamWang1721 3d31be5
Merge main into feat/custom-update-source-minimal
WilliamWang1721 8fecf57
Merge main into feat/custom-update-source-minimal
WilliamWang1721 4684890
Merge main into feat/custom-update-source-minimal
WilliamWang1721 0fcacec
Merge main into feat/custom-update-source-minimal
WilliamWang1721 eba8088
Merge main into feat/custom-update-source-minimal
WilliamWang1721 78473c7
Merge main into feat/custom-update-source-minimal
WilliamWang1721 e5fbb71
Merge main into feat/custom-update-source-minimal
WilliamWang1721 6b3fe65
Merge main into feat/custom-update-source-minimal
WilliamWang1721 acfcf25
Merge main into feat/custom-update-source-minimal
WilliamWang1721 76fbf8b
Merge main into feat/custom-update-source-minimal
WilliamWang1721 7b87458
Merge main into feat/custom-update-source-minimal
WilliamWang1721 aa1464e
Merge main into feat/custom-update-source-minimal
WilliamWang1721 4b967b2
Merge main into feat/custom-update-source-minimal
WilliamWang1721 b4ef6b5
Merge main into feat/custom-update-source-minimal
WilliamWang1721 266989c
Merge main into feat/custom-update-source-minimal
WilliamWang1721 902481f
Merge main into feat/custom-update-source-minimal
WilliamWang1721 7d43878
Merge main into feat/custom-update-source-minimal
WilliamWang1721 87a5337
Merge main into feat/custom-update-source-minimal
WilliamWang1721 f1d16cd
Merge main into feat/custom-update-source-minimal
WilliamWang1721 71bf437
Merge main into feat/custom-update-source-minimal
WilliamWang1721 09793aa
Merge main into feat/custom-update-source-minimal
WilliamWang1721 7b2b12c
Merge main into feat/custom-update-source-minimal
WilliamWang1721 6b76e3b
Merge main into feat/custom-update-source-minimal
WilliamWang1721 f597c6d
Merge main into feat/custom-update-source-minimal
WilliamWang1721 9e66546
Merge main into feat/custom-update-source-minimal
WilliamWang1721 4589758
Merge main into feat/custom-update-source-minimal
WilliamWang1721 bfb0458
Merge main into feat/custom-update-source-minimal
WilliamWang1721 f4bc16f
Merge main into feat/custom-update-source-minimal
WilliamWang1721 3a70432
Merge main into feat/custom-update-source-minimal
WilliamWang1721 6a9c76f
Merge main into feat/custom-update-source-minimal
WilliamWang1721 eb18366
Merge main into feat/custom-update-source-minimal
WilliamWang1721 1896be8
Merge main into feat/custom-update-source-minimal
WilliamWang1721 532b7de
Merge main into feat/custom-update-source-minimal
WilliamWang1721 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
39 changes: 39 additions & 0 deletions
39
architecture/notes/pebrel_app/update_check/2026-09-25-custom-release-source.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # Configurable GitHub Release update source | ||
|
|
||
| ## Status | ||
|
|
||
| Accepted for this PR. | ||
|
|
||
| ## Context | ||
|
|
||
| Pebrel currently checks the official GitHub Releases feed only. Fork builds and preview releases need one optional source override without duplicating the updater pipeline. | ||
|
|
||
| ## Evidence | ||
|
|
||
| The existing updater already owns asset selection, size limits, SHA-256 verification, streamed downloads, and platform install handoff. Only release discovery and trusted repository validation need to vary. | ||
|
|
||
| ## Decision | ||
|
|
||
| Persist one optional `update_release_url`. Empty keeps `Kuddev/pebrel`. A custom value must be an HTTPS GitHub Releases URL. `releases` or `releases/latest` selects the repository's latest release; `releases/tag/<tag>` pins an exact release. | ||
|
|
||
| The official source keeps its existing 403/429 public-page fallback. Custom sources use the GitHub API directly and do not add another fallback protocol. | ||
|
|
||
| ## Rejected alternatives | ||
|
|
||
| A second updater implementation per source was rejected because it would duplicate asset selection, verification, and install logic. Arbitrary download URLs were rejected because they would weaken repository and asset validation. | ||
|
|
||
| ## Consequences | ||
|
|
||
| Existing settings remain unchanged when the field is absent or empty. Changing the source invalidates assets from another repository during download validation. Custom sources must keep Pebrel's existing native package naming and SHA-256 metadata contract. | ||
|
|
||
| ## Validation | ||
|
|
||
| CI covers the architecture note contract, Rust formatting, native tests, and updater tests. The parser also tests latest-release normalization, explicit prerelease tags, and rejection of non-GitHub release URLs. | ||
|
|
||
| ## Supersedes | ||
|
|
||
| None. | ||
|
|
||
| ## Revisit when | ||
|
|
||
| Revisit if Pebrel supports a non-GitHub release backend or if package identity and verification rules become source-specific. |
61 changes: 61 additions & 0 deletions
61
...cture/notes/pebrel_app/update_check/2026-09-28-update-source-result-lifetime.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # Update source result lifetime | ||
|
|
||
| ## Status | ||
|
|
||
| Proposed with PR #294; maintainer review pending. | ||
|
|
||
| ## Context | ||
|
|
||
| The configurable release source is read by manual checks, delayed startup checks, | ||
| and cached download hydration. A request can finish after the source changes or | ||
| Reset All restores the official source. Per-settings-pane sequencing protects | ||
| only one manual check and cannot invalidate startup work or results already queued | ||
| for another window. | ||
|
|
||
| ## Evidence | ||
|
|
||
| - update_check::spawn_once and update_check::spawn_gpui_once publish background results. | ||
| - SettingsPane::check_for_updates can open its prompt after its state update. | ||
| - update_download::cancel invalidates the existing download generation, and | ||
| cached assets are validated against the configured source before reuse. | ||
| - The focused updater tests run through the repository's GitHub Actions workflows. | ||
|
|
||
| ## Decision | ||
|
|
||
| Increment one process-local generation when the release source changes or all | ||
| settings reset. Each manual or startup check captures its generation and drops a | ||
| result when it is no longer current. GPUI update events carry the generation until | ||
| the main event dispatcher applies them. The About page also keeps its existing | ||
| per-pane sequence for repeated checks. Source invalidation clears the pane's | ||
| displayed check result and cancels the current download session. | ||
|
|
||
| ## Rejected alternatives | ||
|
|
||
| Comparing source URLs alone would accept an old result if the setting changed | ||
| away and back while that request was running. Per-pane sequencing alone leaves | ||
| startup checks and another window's event queue unprotected. Cancelling every | ||
| network request would require new ownership across the synchronous release | ||
| fetcher; ignoring stale results uses the existing generation-based pattern. | ||
|
|
||
| ## Consequences | ||
|
|
||
| Changing or resetting the source invalidates old results across all windows. | ||
| A check for the current generation remains usable. A stale cached asset does not | ||
| become installable because the existing asset validation still checks its source. | ||
|
|
||
| ## Validation | ||
|
|
||
| The regression is | ||
| update_check::tests::invalidating_the_release_source_rejects_an_in_flight_result. | ||
| The PR description records GitHub Actions status for the final head; this note | ||
| does not claim UI end-to-end validation. | ||
|
|
||
| ## Supersedes | ||
|
|
||
| None. This records result lifetime for | ||
| [the configurable release source](2026-09-25-custom-release-source.md). | ||
|
|
||
| ## Revisit when | ||
|
|
||
| Revisit if release checks become cancellable and are actually cancelled on source | ||
| change, or if the updater moves source-generation ownership to another module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.