Skip to content

Preserve user-edited WSL registry subtrees during installer cleanup - #1043

Merged
Kuddev merged 1 commit into
review/static-output-snapshots-1119from
fix/installer-wsl-verb-ownership-1119
Nov 20, 2026
Merged

Kuddev merged 1 commit into
review/static-output-snapshots-1119from
fix/installer-wsl-verb-ownership-1119

Conversation

@Kuddev

@Kuddev Kuddev commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

An Inno upgrade or uninstall can recursively remove user-created subkeys attached to an existing Pebrel WSL verb. It previously accepted the command string as proof of ownership even if the verb also contained other keys.

This extracts the registry ownership fix from WilliamWang1721's #456. Cleanup checks the shape of both cascading and legacy flat WSL verbs before removing them. A conflicting cascading menu stops registration and preserves the edited keys. The installation wizard and menu choices remain in #456.

The existing isolated HKCU fixture now covers both directory roots, edits immediately below a verb or its command, and preservation during registration and cleanup. The local architecture and whitespace checks passed. On Windows x64, the baseline reproduced the registry loss. The candidate passed 149 migration checks, full Inno installer compilation, and 22 launch checks with the real Run entry and shutdown restore. Native Windows acceptance. The review base is #1041.

Port the WSL verb ownership checks from WilliamWang1721's #456 and exercise them in the existing installer migration fixture.
@github-actions github-actions Bot added the size/S ≤100 行源码改动 label Nov 19, 2026
@Kuddev
Kuddev merged commit b65051c into review/static-output-snapshots-1119 Nov 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S ≤100 行源码改动

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant