Repository navigation
Conversation
Port the WSL verb ownership checks from WilliamWang1721's #456 and exercise them in the existing installer migration fixture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An Inno upgrade or uninstall can recursively remove user-created subkeys attached to an existing Pebrel WSL verb. It previously accepted the command string as proof of ownership even if the verb also contained other keys.
This extracts the registry ownership fix from WilliamWang1721's #456. Cleanup checks the shape of both cascading and legacy flat WSL verbs before removing them. A conflicting cascading menu stops registration and preserves the edited keys. The installation wizard and menu choices remain in #456.
The existing isolated HKCU fixture now covers both directory roots, edits immediately below a verb or its command, and preservation during registration and cleanup. The local architecture and whitespace checks passed. On Windows x64, the baseline reproduced the registry loss. The candidate passed 149 migration checks, full Inno installer compilation, and 22 launch checks with the real Run entry and shutdown restore. Native Windows acceptance. The review base is #1041.