Repository navigation
fix:navigate workflow run action to detail page - #117
Athulya-936 wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe workflow list Run action now navigates to ChangesWorkflow Run Navigation
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The Run action routes to the selected workflow detail page without retaining the placeholder toast behavior. The change is ready to merge. 🚥 Pre-merge checks | ✅ 5 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation Issue ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 608e62ee-5fdb-4fd4-8858-987b60217283
📒 Files selected for processing (1)
app/dashboard/workflow/page.tsx
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
|
Hey @Athulya-936 |
|
Thanks for your contributions - could you please sign your commits? else its looks good to me |
18cfb3d to
b3300ed
Compare
|
Hi @mohit-nagaraj I’ve signed both commits as requested. Could you please let me know if there’s anything else needed from my side? |
What this PR does / why we need it
Fixes the Run action in the workflow list.
Previously, clicking the Run action displayed the
"Run functionality coming soon" toast instead of taking the user to the
workflow's existing detail page.
This change updates the Run action to navigate to:
/dashboard/workflow/${workflow.id}The existing
stopPropagation()behavior is preserved so clicking Run doesnot trigger the parent workflow row click.
Which issue(s) this PR fixes
Fixes #105
Special notes for your reviewer
e.stopPropagation().app/dashboard/workflow/page.tsx.app/dashboard/workflow/new/page.tsxwas not changed because it is a separate route for creating a new workflow.Checklist
Validation
npm run test:run— 100 tests passednpm run type-check— passedgit diff --check— passedRelease note
NONE