Skip to content

fix:navigate workflow run action to detail page - #117

Open
Athulya-936 wants to merge 2 commits into
KubeOrch:mainfrom
Athulya-936:fix/105-workflow-run-navigation
Open

Athulya-936 wants to merge 2 commits into
KubeOrch:mainfrom
Athulya-936:fix/105-workflow-run-navigation

Conversation

@Athulya-936

Copy link
Copy Markdown

What this PR does / why we need it

Fixes the Run action in the workflow list.

Previously, clicking the Run action displayed the
"Run functionality coming soon" toast instead of taking the user to the
workflow's existing detail page.

This change updates the Run action to navigate to:

/dashboard/workflow/${workflow.id}

The existing stopPropagation() behavior is preserved so clicking Run does
not trigger the parent workflow row click.

Which issue(s) this PR fixes

Fixes #105

Special notes for your reviewer

  • Removed the placeholder "Run functionality coming soon" toast.
  • Added navigation from the workflow list Run action to the workflow detail page.
  • Preserved e.stopPropagation().
  • No changes were made to the existing workflow run functionality on the detail page.
  • The change is limited to app/dashboard/workflow/page.tsx.
  • app/dashboard/workflow/new/page.tsx was not changed because it is a separate route for creating a new workflow.

Checklist

  • Design: Not required for this change
  • PR: Description explains the change and reason
  • Code: Change is limited and follows the existing implementation
  • Refactor: No unrelated refactoring was performed
  • Upgrade: Not applicable
  • Testing: Existing test suite passes
  • Documentation: Not required for this change
  • Community: Not required for this change

Validation

  • npm run test:run — 100 tests passed
  • npm run type-check — passed
  • git diff --check — passed
  • ESLint for the changed file — passed

Release note

NONE

@coderabbitai

coderabbitai Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 525fff71-9123-4570-8168-78414881cc23

📥 Commits

Reviewing files that changed from the base of the PR and between f46ccf6 and 18cfb3d.

📒 Files selected for processing (2)
  • app/dashboard/workflow/_tests_/page.test.tsx
  • app/dashboard/workflow/page.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/dashboard/workflow/page.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The workflow list Run action now navigates to /dashboard/workflow/{workflow.id}. The previous “coming soon” toast was removed, and a focused test verifies the navigation.

Changes

Workflow Run Navigation

Layer / File(s) Summary
Route and verify the Run action
app/dashboard/workflow/page.tsx, app/dashboard/workflow/_tests_/page.test.tsx
The Run action navigates to the selected workflow detail page and no longer displays the placeholder toast. The test verifies the route for workflow-123.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 18cfb

The Run action routes to the selected workflow detail page without retaining the placeholder toast behavior. The change is ready to merge.

🚥 Pre-merge checks | ✅ 5 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning Issue #105 implementation requirements are met in app/dashboard/workflow/page.tsx: the Run item has no placeholder toast, uses /dashboard/workflow/${workflow.id}, and calls stopPropagation(). Th… Extend app/dashboard/workflow/_tests_/page.test.tsx to verify keyboard activation and to assert that the placeholder message or toast is not shown. Retain the existing navigation assertion.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the navigation change, preserved event behavior, test coverage, validation, and linked issue.
Linked Issues check ✅ Passed The description references issue #105, and the implementation directly addresses its stated requirement to replace the Run placeholder with detail-page navigation.
Out of Scope Changes check ✅ Passed The implementation and focused test remain within the stated workflow Run navigation scope. No backend, detail-page, or new-workflow-route changes were introduced.
Title check ✅ Passed The title clearly identifies the workflow Run action navigation fix and matches the primary change.
Out of Scope Changes check ✅ Passed The changes are limited to the workflow-list Run action and its focused test. They do not change backend execution, workflow cards, clone, edit, archive, or workflow-detail behavior. The changes suppo…
Full details: Linked Issues check

Explanation

Issue #105 implementation requirements are met in app/dashboard/workflow/page.tsx: the Run item has no placeholder toast, uses /dashboard/workflow/${workflow.id}, and calls stopPropagation(). The shared onClick handler supports the menu component's pointer and keyboard activation. The new test in app/dashboard/workflow/_tests_/page.test.tsx verifies pointer navigation and the workflow ID, but it does not verify keyboard activation or assert the absence of the placeholder message. This does not meet the issue's focused test acceptance criterion.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 608e62ee-5fdb-4fd4-8858-987b60217283

📥 Commits

Reviewing files that changed from the base of the PR and between 0208a32 and f46ccf6.

📒 Files selected for processing (1)
  • app/dashboard/workflow/page.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread app/dashboard/workflow/page.tsx Resolved
@mohit-nagaraj

Copy link
Copy Markdown
Member

Hey @Athulya-936
The ci is failing can you please take a look? Also make sure to address the review comments. Do not forget on signing the commits.

@mohit-nagaraj

Copy link
Copy Markdown
Member

Thanks for your contributions - could you please sign your commits? else its looks good to me

@Athulya-936
Athulya-936 force-pushed the fix/105-workflow-run-navigation branch from 18cfb3d to b3300ed Compare September 19, 2026 07:50
@Athulya-936

Copy link
Copy Markdown
Author

Hi @mohit-nagaraj I’ve signed both commits as requested. Could you please let me know if there’s anything else needed from my side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Workflow] Replace the workflow-list Run stub with the real run path

2 participants