Skip to content

[Notifications] Support write-only secrets in channel forms #119

Open

Description

@mohit-nagaraj

Context

Parent: KubeOrch/core#137
Blocked by: KubeOrch/core#142

The notification form currently repopulates edit fields from channel.config, which assumes stored webhook URLs, tokens, routing keys, and custom header values are readable. The hardened Core contract will return configured indicators and safe metadata instead.

Outcome

Users can create and rotate notification credentials without the UI ever reading, reconstructing, or displaying a stored secret.

Scope

  • Update TypeScript request/response types to match the redacted Core DTO.
  • Render secret inputs empty during edit with an accessible ?configured? state.
  • Omit untouched secret fields from update requests.
  • Send a replacement only when the user enters a new value, and use an explicit control for removal if Core supports it.
  • Treat custom-header values as secrets while allowing safe header names where the contract permits.
  • Add focused service, store, and form tests.

Out of scope

  • Core encryption or migration logic.
  • Delivery-history UI.
  • A full integrations-page redesign.
  • Adding notification providers.

Acceptance criteria

  • No saved secret appears in component state, rendered text, logs, or screenshots.
  • Metadata-only edits do not clear configured secrets.
  • Rotation and explicit removal produce the correct request shape.
  • Keyboard and screen-reader users can understand configured, replace, and remove states.
  • Failed requests do not falsely report that credentials were updated.

Verification

  • Focused Vitest and Testing Library tests pass.
  • npm run type-check passes.
  • Include create/edit screenshots using dummy values only.

Activity

  1. bernalalexis-try commented on Sep 16, 2026

    @bernalalexis-try

    working on it

  2. bernalalexis-try commented on Sep 16, 2026

    @bernalalexis-try

    Closed in #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions