Bump vendored helper deps to versions that actually close the advisories - #20
Merged
Conversation
The four open Dependabot PRs do not resolve their own alerts: #16 targets time 0.3.26 (patched 0.3.47), #17 serde_with 2.3.2 (patched 3.21.0), and #18 rustix 0.36.7 (patched 0.36.16). Only #15 (unsafe-libyaml) reaches a fixed version. Merging all four would leave three alerts open while looking resolved. Go to the patched versions directly. serde_with needs a major bump, so its requirement moves from 2.2 to 3.21; the only API used is the DeserializeFromStr derive in src/keyboard/mod.rs, which is unchanged in 3.x. 43 helper tests and 116 app tests pass. None of the four is reachable in this binary — the rustix issue is in the linux_raw backend, unsafe-libyaml's affects no 64-bit target, and neither RFC 2822 parsing nor KeyValueMap appears in the source. This is supply- chain hygiene, not a fix for a live risk. Cargo.toml and Cargo.lock now differ from the pinned upstream commit; no Rust source is touched. Recorded in THIRD_PARTY_NOTICES.md. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces Dependabot PRs #15–#18.
Three of those four bump into versions that are still inside their own vulnerable range, so merging them would close the PRs while leaving the alerts open:
This goes to the patched versions directly.
serde_withneeds a major bump (2.2 to 3.21); the only API the helper uses is theDeserializeFromStrderive insrc/keyboard/mod.rs, unchanged in 3.x.None of the four is reachable in this binary. The
rustixissue lives in thelinux_rawbackend, which Darwin never selects;unsafe-libyaml's advisory states no 64-bit target is affected; and neither RFC 2822 parsing norKeyValueMapappears anywhere in the helper source. This is supply-chain hygiene, not a fix for a live risk.Note on provenance:
Cargo.tomlandCargo.locknow diverge from the pinned upstream commitaff33824. No Rust source file is touched. Recorded inTHIRD_PARTY_NOTICES.md.Verified locally: 43 helper tests, 116 app tests, 1 hardware test skipped, 0 failures.
After merging, close #15–#18.
🤖 Generated with Claude Code