ci: enable lenient DCO App config + skip test on docs-only PRs - #137
Merged
Conversation
- Add .github/dco.yml for the org-wide dcoapp GitHub App: require.members:false + allowRemediationCommits so a missing sign-off is fixed with one remediation commit instead of a rebase. nautilus had no DCO before; the org-wide app now posts a DCO check, and this keeps it lenient instead of strict-by-default. - Gate the required `test` matrix job on a new `code` paths-filter output so docs-only PRs skip it; a skipped required check counts as a pass, so those PRs stay mergeable. - CONTRIBUTING + new PR template: document sign-off + no-rebase remediation. - pre-commit: tell codespell `thirdParty` (a dcoapp key) is not a typo. Signed-off-by: Sean Mauk <seanmauk@krakennetworks.com>
krakennetworks
self-requested a review
June 25, 2026 16:11
krakennetworks
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two outward-facing CI changes, mirroring the proven stargraph PR #161:
A. Lenient, documented DCO App config. nautilus never had DCO; the org-wide
dcoappGitHub App now posts aDCOstatus check that defaults to strict. Thisadds
.github/dco.ymlto keep it lenient:require.members: false— commits by KrakenNet org members don't need a sign-off line.allowRemediationCommits.{individual,thirdParty}: true— a missing sign-off isfixed by pushing one remediation commit (the app comments the exact command)
instead of rewriting history with a rebase;
thirdPartyalso lets a maintainersign off an unsigned bot commit (e.g. autofix.ci) that would otherwise deadlock DCO.
It also documents sign-off + the no-rebase remediation flow in
CONTRIBUTING.mdand the PR template, and tells codespell that
thirdParty(a dcoapp config key)is not a typo.
B. Skip the
testjob on docs-only PRs. Adds achangespaths-filter job andgates the required
testmatrix on itscodeoutput. A docs-only PR now skipstest; a skipped required check counts as a pass in branch protection, so docsPRs stay mergeable without burning the full toolchain. Negation-only filter is
fail-safe: if dorny ever ignored the
!patterns,**matches everything andtestruns anyway.Changes
.github/dco.yml(new) — lenient dcoapp config..github/workflows/ci.yml— newchangesjob;testgated onneeds: changes+codeoutput..pre-commit-config.yaml— codespell-L thirdparty+ explanatory comment.CONTRIBUTING.md— new "Sign-off (DCO)" section (sign-off + no-rebase remediation)..github/pull_request_template.md— add a DCO sign-off checklist item.Testing
yaml.safe_load(ci.yml, dco.yml, pre-commit) — parses clean.changesis the first job andtestcarriesneeds: changes+ theif:gate.docs/,mkdocs.yml,LICENSEall present)..github/(code), so thetestmatrix runs here (does not skip).Related Issues
Mirrors KrakenNet/stargraph#161.
🤖 Generated with Claude Code