Repository navigation
fix(rx-coverage): English tooltips for the leaderboard score and cells columns - #2280
Merged
Merged
Conversation
…s columns Both column tooltips were in Dutch since Kpa-clawbot#1728. The score text now says what rx_dashboard.go computes: per cell, 1 divided by the number of observers that heard something there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The RX coverage leaderboard has two column tooltips in Dutch, since #1728 (
public/rx-coverage.js:340and:342). The rest of the UI is English.Change
cmd/server/rx_dashboard.go:362-366computes. Each ~150 m cell (leaderboardHexRes = 13,rx_dashboard.go:264) adds 1 divided by the number of observers that heard something there, so an unshared cell counts 1 and a cell shared with 3 others counts 0.25.No logic changes, so there is no new test.
sh test-all.shpasses. Not done: no browser check of the tooltips.Noticed in the review of #2269, which had picked the Dutch text up as an English key.