release: 0.3.1 — queue-overlay fix, Shorts save-trigger fallback - #24
Merged
Conversation
Move Configuration to the top of the keyboard-shortcuts spec so the customization options are found before the command reference. Add prefix-change, chord-remap, and non-QWERTY remap examples, and note the default chords are chosen to avoid colliding with YouTube's own single-key shortcuts.
Point Edge and Arc at the Chrome Web Store listing directly (both are Chromium-based, confirmed via Microsoft/Arc docs) instead of a bare dash, and note Edge needs 'Allow extensions from other stores' enabled first while Arc installs without extra setup.
Drop the inline parenthetical from the Listing column and mark Edge and Arc as Unofficial* in Status instead, with the Chromium-install caveat explained once below the table.
YouTube moved role="menuitem" off yt-list-item-view-model onto its inner button/anchor (wrapper is now role="presentation"), so the queue popup opened but the "Add to queue" item was never found, silently no-opping. Select the descendant instead of the wrapper.
…trigger findSaveToPlaylistTrigger only looked for the /watch page's action-row button, so Ctrl+A Shift+P silently no-op'd on the Shorts standalone player (issue #20). A captured Shorts-page JSON snapshot confirms YouTube offers "Save to playlist" there via the header "..." menu, so add ytd-reel-player-header-renderer ytd-menu-renderer button as a fallback, derived from JSON renderer names and this codebase's established naming convention but not yet confirmed against a live DOM.
Patch release covering the queue-overlay menuitem-selector fix and the Shorts save-to-playlist trigger fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
role="menuitem"off the popup item wrapper onto its inner button/link)Supersedes #23.
mainhad drifted fromdev(a past "promote dev to main" replayed dev's commits onto main with new hashes instead of fast-forwarding), so a straightdev→mainPR 3-way-conflicted despite the content being identical. This branch isorigin/main's actual tip (055d86a) with the 7 new commits since then rebased cleanly on top — verified the resulting tree is byte-identical todev's tip before merging.Test plan
bash scripts/check.sh— syntax/manifest checks passbash scripts/test.sh— 338/338 unit tests passgit diffempty) before pushingrelease-firefox.ymlandrelease-chrome.ymlonmain— will monitor