retro: record PR for issue #20 (already merged to dev) - #21
Closed
Kotmin wants to merge 3 commits into
Closed
Conversation
YouTube moved role="menuitem" off yt-list-item-view-model onto its inner button/anchor (wrapper is now role="presentation"), so the queue popup opened but the "Add to queue" item was never found, silently no-opping. Select the descendant instead of the wrapper.
…trigger findSaveToPlaylistTrigger only looked for the /watch page's action-row button, so Ctrl+A Shift+P silently no-op'd on the Shorts standalone player (issue #20). A captured Shorts-page JSON snapshot confirms YouTube offers "Save to playlist" there via the header "..." menu, so add ytd-reel-player-header-renderer ytd-menu-renderer button as a fallback, derived from JSON renderer names and this codebase's established naming convention but not yet confirmed against a live DOM.
Owner
Author
|
Closing — this PR was opened purely as a reviewable record of commits already merged directly to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record-only PR
These three commits already landed on
devvia a direct push (branch protection was bypassed by an admin-rights account) before the repo switched to a PR-required workflow. This PR exists purely to give them a reviewable diff and a permanent record — it is not meant to be merged;devalready contains this work.Closes-by-reference: #20
Commits
ceb3d02fix(queue-overlay): match menuitem role on popup item's inner buttoncbd91d2feat(playlist): add best-effort Shorts fallback for save-to-playlist trigger52dfef3docs(changelog): note queue-overlay and Shorts save-trigger fixesRoot cause summary
role="menuitem"off the popup item wrapper onto its inner button/link.Shift+P) no-op'd on Shorts specifically: the watch-page trigger selector doesn't exist on the Shorts player; added a best-effort fallback to the Shorts header "..." menu, flagged as not yet live-confirmed (docs/ai/questions-for-K.mdQ17).Going forward, changes to
devin this repo go through a PR instead of a direct push.