[pull] main from libsdl-org:main - #131
Merged
Merged
Conversation
Re-flow the documentation to avoid overly long lines, disable insets when display scaling is enabled, and skip a large inset-related code block when configuring window geometry if it's not needed.
Preserve the supplied size when creating a constant memory stream so lazy properties report the correct buffer size. Extend the existing constant memory test to check that property.
Re-enable insets in display scaling mode, as it is clear that the insets are always in scaled points when doing so. Additionally, note that compositors may ignore min/max size hints or the non-resizable state on windows, and when insets are used, clients are responsible for handling this, as SDL can't mask around the main surface or use viewports to correct for this behavior.
Only publish stream property groups after all initializer calls succeed. Destroy incomplete groups and allow retry so failed property insertion cannot orphan a dynamic stream's existing buffer. Add an isolated allocation failure regression covering close, retry, and explicit ownership transfer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )