Skip to content

fix: add missing ARM64 tokenizer dependency for Docker - #253

Open
wasim-builds wants to merge 3 commits into
KnockOutEZ:mainfrom
wasim-builds:fix-issue-231
Open

fix: add missing ARM64 tokenizer dependency for Docker#253
wasim-builds wants to merge 3 commits into
KnockOutEZ:mainfrom
wasim-builds:fix-issue-231

Conversation

@wasim-builds

@wasim-builds wasim-builds commented Jul 29, 2026

Copy link
Copy Markdown

Hey! The Docker image was missing the ARM64 build of @anush008/tokenizers, causing the vector search to silently degrade. I've added @anush008/tokenizers-linux-arm64-gnu to the optionalDependencies so it gets picked up during the Docker build. Let me know if everything looks good!

Summary by CodeRabbit

  • Chores
    • Improved Linux ARM64 compatibility by allowing compatible 0.5.x tokenizer versions.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b49f87ec-b810-4e66-bd87-915dba7c241c

📥 Commits

Reviewing files that changed from the base of the PR and between 12a363e and 7bad475.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Updates the optional Linux ARM64 tokenizer dependency in package.json to accept compatible 0.5.x versions.

Changes

Tokenizer dependency

Layer / File(s) Summary
Optional ARM64 package version constraint
package.json
Changes @anush008/tokenizers-linux-arm64-gnu from exact version 0.5.0 to ^0.5.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 7bad4

This localized dependency update is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Suggested reviewers: knockoutez

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the ARM64 tokenizer dependency change for Docker builds. It matches the pull request objective and uses concise, specific wording.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Frankie-Xu

This comment was marked as spam.

Frankie-Xu

This comment was marked as spam.

Frankie-Xu

This comment was marked as spam.

Copilot AI lite review requested due to automatic review settings August 27, 2026 18:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants