Skip to content

Create a fresh parser per benchmark iteration #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kludex merged 2 commits into from
Aug 9, 2026
+24 −21
Merged

Create a fresh parser per benchmark iteration #318

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6f98b1
Create a fresh parser per benchmark iteration
Kludex Aug 9, 2026
c3186eb
Start new benchmark series for complete parses
Kludex Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 24 additions & 21 deletions tests/test_benchmarks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from __future__ import annotations

import string
from collections.abc import Iterator
from typing import TYPE_CHECKING

import pytest
Expand Down Expand Up @@ -81,37 +80,41 @@ def split(data: bytes, chunk_size: int = CHUNK_SIZE) -> list[bytes]:
URLENCODED_LARGE = b"&".join(f"field{i}={'v' * 64}".encode() for i in range(100))


@pytest.fixture
def multipart_parser() -> Iterator[MultipartParser]:
parser = MultipartParser(BOUNDARY, MULTIPART_CALLBACKS)
yield parser
parser.finalize()
def make_multipart_parser() -> MultipartParser:
return MultipartParser(BOUNDARY, MULTIPART_CALLBACKS)


@pytest.fixture
def querystring_parser() -> Iterator[QuerystringParser]:
parser = QuerystringParser(QUERYSTRING_CALLBACKS)
yield parser
parser.finalize()
def make_querystring_parser() -> QuerystringParser:
return QuerystringParser(QUERYSTRING_CALLBACKS)


def test_multipart_simple_form(multipart_parser: MultipartParser) -> None:
multipart_parser.write(SIMPLE_FORM)
def test_parse_multipart_simple_form() -> None:
parser = make_multipart_parser()
parser.write(SIMPLE_FORM)
parser.finalize()


def test_multipart_large_form(multipart_parser: MultipartParser) -> None:
multipart_parser.write(LARGE_FORM)
def test_parse_multipart_large_form() -> None:
parser = make_multipart_parser()
parser.write(LARGE_FORM)
parser.finalize()


def test_multipart_file_upload(multipart_parser: MultipartParser) -> None:
def test_parse_multipart_file_upload() -> None:
parser = make_multipart_parser()
for chunk in FILE_UPLOAD_CHUNKS:
multipart_parser.write(chunk)
parser.write(chunk)
parser.finalize()


def test_multipart_worstcase_boundary_chars(multipart_parser: MultipartParser) -> None:
def test_parse_multipart_worstcase_boundary_chars() -> None:
parser = make_multipart_parser()
for chunk in WORSTCASE_BCHAR_CHUNKS:
multipart_parser.write(chunk)
parser.write(chunk)
parser.finalize()


def test_querystring_large_form(querystring_parser: QuerystringParser) -> None:
querystring_parser.write(URLENCODED_LARGE)
def test_parse_querystring_large_form() -> None:
parser = make_querystring_parser()
parser.write(URLENCODED_LARGE)
parser.finalize()
Loading