Speed up querystring callback dispatch - #316
Conversation
Merging this PR will improve performance by 70.17%
Performance Changes
Tip Curious why this is faster? Comment Comparing |
|
Thanks. The final revision retains the improvement: CodSpeed reports a 70.17% efficiency improvement for |
|
Updated callback dispatch in b1c3c9e to use shared |
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Summary
QuerystringParsercallbacks through fixed callback keys once per input chunk instead of usingBaseParser.callback()for every eventPerformance
The latest CodSpeed simulation reports a 70.17% efficiency improvement for
test_querystring_large_form, from 912.9 µs to 536.5 µs. A same-environment local wall-time benchmark on Python 3.13 improved from approximately 80 µs to 49 µs (about 39%). The other four CodSpeed benchmarks are unchanged.Validation