Hide test output details behind view - #4001
Merged
Merged
Conversation
CDash currently stores all tests in a `build2test` table, with test output stored deduplicated in a separate `testoutput` table. The deduplication step currently relies on the `output` being selective enough to identify entire unique `(path,command,output)` tuples, which is not always the case. Since Postgres doesn't support composite hash indexes and the data is too big for b-tree indexes (and other index types), we don't have an efficient way to look up unique tuples. This PR adds a new index on the hash of the data, as well as a view to hide the implementation details of the deduplication process. This PR was designed for maximum compatibility, but I intend to follow this with a series of refactors to gradually remove all application-level references to the `build2test` and `testoutput` tables.
josephsnyder
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CDash currently stores all tests in a
build2testtable, with test output stored deduplicated in a separatetestoutputtable. The deduplication step currently relies on theoutputbeing selective enough to identify entire unique(path,command,output)tuples, which is not always the case. Since Postgres doesn't support composite hash indexes and the data is too big for b-tree indexes (and other index types), we don't have an efficient way to look up unique tuples. This PR adds a new index on the hash of the data, as well as a view to hide the implementation details of the deduplication process. This PR was designed for maximum compatibility, but I intend to follow this with a series of refactors to gradually remove all application-level references to thebuild2testandtestoutputtables.