Update testoutput.id migration to not require superuser - #3996
Merged
williamjallen merged 1 commit intoSep 16, 2026
Merged
williamjallen merged 1 commit into
williamjallen merged 1 commit into
Conversation
The `testoutput` ID column migration currently fails for instances where the postgres user is not a superuser. This resolves the issue by only disabling user triggers. A side effect of this change is that foreign-key constraints are no longer disabled, which may slow down the migration on some systems.
zackgalbreath
approved these changes
Sep 16, 2026
|
We've not been seeing serial test results from HDF5 builds on HPC machines, nor test results from HDF5 Github Daily tests since 9/10/2026. We are still seeing parallel test results. Claude's analysis of the difference is that the serial and github daily test results are affected by this issue because there are typically ~3250 test results, while there are ~266 parallel test results. Will this PR address that problem in v5.4.0? Is there any approximate expected date for an update to https://my.cdash.org that will fix the problem? Our test results on CDash are back to normal now as of ~yesterday when I posted this. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testoutputID column migration currently fails for instances where the postgres user is not a superuser. This resolves the issue by only disabling user triggers. A side effect of this change is that foreign-key constraints are no longer disabled, which may slow down the migration on some systems.