Remove engineCommandManager, rustContext from singletons#10252
Merged
franknoirot merged 10 commits intomainfrom Mar 6, 2026
Merged
Remove engineCommandManager, rustContext from singletons#10252franknoirot merged 10 commits intomainfrom
engineCommandManager, rustContext from singletons#10252franknoirot merged 10 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
franknoirot
force-pushed
the
franknoirot/9956/remove-ecm-rc-singletons
branch
from
d7fe437 to
6e3567a
Compare
franknoirot
force-pushed
the
franknoirot/9956/remove-ecm-rc-singletons
branch
from
6e3567a to
5202e5f
Compare
They're available off of the currently-executing editor (`kclManager` is what we call that today).
franknoirot
changed the base branch from
main
to
franknoirot/9956/update-sceneInfra-sceneentities-use
franknoirot
force-pushed
the
franknoirot/9956/remove-ecm-rc-singletons
branch
from
5202e5f to
8893b24
Compare
Base automatically changed from
franknoirot/9956/update-sceneInfra-sceneentities-use
to
main
March 6, 2026 13:56
jacebrowning
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They now hang off of the currently-executing editor (
kclManageris what we call that today), so just replace uses of these two subsystems with them throughkclManager. Split out from #10173 as this is the noisy "change a bunch of files" update after that hard logic migration.