Change panic behavior to the default of unwind#10228
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merging this PR will not alter performance
Comparing Footnotes
|
Related: #10121. Note: wasm32-unknown-unknown doesn't currently implement unwinding, so that target is unaffected by this change. https://doc.rust-lang.org/rustc/platform-support/wasm32-unknown-unknown.html#unwinding
cd482cf to
4042b6a
Compare
adamchalmers
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #10121.
The primary motivation of this is so that Python code using the bindings can catch any panics in the Rust code, rather than the panic aborting the process.
PanicException. I did this locally, but I don't think it's worth committing since it requires triggering a panic. Also, I learned that for async Rust, we handle it and raiseExceptioninstead. But it's not guaranteed, so it's good to catchPanicExceptionalso.modeling-app/rust/kcl-python-bindings/src/lib.rs
Line 47 in 092129a
Note: wasm32-unknown-unknown doesn't currently implement unwinding, so that target is unaffected by this change. https://doc.rust-lang.org/rustc/platform-support/wasm32-unknown-unknown.html#unwinding
It was originally set in #207.