Repository navigation
Compile all QML on Qt 6.4 in CI; add omavm version - #4
Merged
Merged
Conversation
Main, Viewer, TerminalViewer, ThemeScrim and Icon were never loaded by a test, so a construct only newer Qt accepts (a variable named long) would pass CI and break the app on Qt 6.4. tst_compile.qml compiles them with the real DisplayView/TerminalView types registered, which also catches a property the viewers set that the C++ type doesn't have.
make dist and the PKGBUILD stamp it with -X main.version; go install falls back to the module version, a local build to Go's VCS stamp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tst_compile.qmlcompiles the top-level QML files no other test loaded (Main, Viewer, TerminalViewer, ThemeScrim, Icon) with the real C++ types registered. Checked locally by injecting a syntax error in Main.qml and an unknown DisplayView property in Viewer.qml: both fail with file and line.omavm version/--version, stamped bymake dist(release tarball) and the PKGBUILD.