Skip to content

modified UI - #6

Merged
Niro0526 merged 1 commit into
masterfrom
niroja
Sep 4, 2026
Merged

Niro0526 merged 1 commit into
masterfrom
niroja

Conversation

@Niro0526

@Niro0526 Niro0526 commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@Niro0526
Niro0526 merged commit 31fd375 into master Sep 4, 2026
1 of 2 checks passed
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Complete 2025 cutoff mappings and distinguish unavailable cutoffs

🐞 Bug fix ✨ Enhancement 📝 Documentation 🕐 10-20 Minutes

Grey Divider

AI Description

• Adds 85 missing district cutoff records for music and aesthetic programmes.
• Resolves handbook aliases that previously prevented course and university matching.
• Separates cutoff-unavailable courses from genuinely ineligible recommendations.
Diagram

graph TD
  A["Section 9 Data"] --> B["Alias Normalizer"] --> C[("Cutoff Dataset")] --> D["Recommendation Query"] --> E["Result Groups"]
  E --> F["Eligible"] & G["Not Eligible"] & H["Cutoff Unavailable"]
Loading
High-Level Assessment

The targeted alias rules and explicit cutoff-unavailable group are appropriate. Treating missing cutoffs as non-eligible was considered but rejected because NQC and new courses represent unknown cutoff status rather than failed eligibility.

Files changed (4) +630 / -140

Enhancement (1) +28 / -11
official-handbook-query.tsIntroduce a separate cutoff-unavailable recommendation group +28/-11

Introduce a separate cutoff-unavailable recommendation group

• Adds Arts stream mappings for the newly resolved programmes. Courses meeting handbook requirements without a district cutoff now receive a dedicated group and deterministic alphabetical ordering instead of being marked ineligible.

backend/src/db/official-handbook-query.ts

Bug fix (2) +597 / -0
zscore_cutoffs_2025.jsonAdd missing music and aesthetic programme cutoffs +595/-0

Add missing music and aesthetic programme cutoffs

• Adds 85 district-level 2024/25 cutoff records for Creative Music Technology and Production, Drama & Theatre, Dance, Music, and Visual & Technological Arts.

HandBook/2025/zscore_cutoffs_2025.json

handbook-2025-normalizer.tsNormalize creative music and Vipulananda identities +2/-0

Normalize creative music and Vipulananda identities

• Adds aliases for the Sri Jayewardenepura creative music course and the canonical Swamy Vipulananda institute name. These mappings allow previously unmatched Section 9 rows to resolve to course identities.

backend/src/db/handbook-2025-normalizer.ts

Documentation (1) +5 / -129
data_quality_report.mdRefresh cutoff normalization quality metrics +5/-129

Refresh cutoff normalization quality metrics

• Updates normalized cutoff totals and issue counts after resolving 85 additional rows. Removes resolved aesthetic-programme mismatches and confirms that no cutoff rows remain pending review.

HandBook/2025/data_quality_report.md

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can route each action level your way: inline, summary, both, or drop

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant