Repository navigation
Fix constraints missing vperp term - #486
Open
LucasMontoya4 wants to merge 2 commits into
Open
LucasMontoya4 wants to merge 2 commits into
LucasMontoya4 wants to merge 2 commits into
Conversation
…_constraints.jl and boundary_conditions.jl
…that in moment_kinetic_2V_tests.jl, the changes to the final phi values introduced for the test case of evolve_p = true are roughly 5 times closer on average to the equivalent values of phi in the case where evolve_n,upar = true but evolve_p = false. This suggests that the changes here bring the evolve_p=true case more in line with the other evolve_moments cases, which is good. However, for the trapping tests, the phi values of the evolve_p = true case were not statistically any closer to the equivalent phi values for other evolve_moments cases. This suggests that another error is dominating in this case, perhaps too low a resolution in velocity space of the test, for example. I will write some high resolution 2V tests so that we can ensure that, like this moment_constraints.jl bug, any other code bugs are more likely to be exposed through disparity in test values of phi in the future, rather than being drowned out by the differences between evolve_moments cases that are naturally induced by low resolution.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made to fix Issue #464. Thanks John for noticing this mistake!