fix: address all high/medium/low issues from code review #5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| package config | ||
|
|
||
| import ( | ||
| "os" | ||
| "path/filepath" | ||
| "testing" | ||
| "time" | ||
| ) | ||
|
|
||
| func TestLoadFallsBackToDefaultsWhenFileMissing(t *testing.T) { | ||
| cfg, err := Load(filepath.Join(t.TempDir(), "nonexistent-config-test.json")) | ||
| if err != nil { | ||
| t.Fatalf("Load() error = %v, want nil for missing file", err) | ||
| } | ||
| if cfg.Port != 3000 { | ||
| t.Fatalf("Port = %d, want default 3000", cfg.Port) | ||
| } | ||
| if cfg.APIBase != "https://api.commandcode.ai" { | ||
| t.Fatalf("APIBase = %q, want default", cfg.APIBase) | ||
| } | ||
| if cfg.UseProviderModels != true { | ||
| t.Fatalf("UseProviderModels = %v, want true", cfg.UseProviderModels) | ||
| } | ||
| } | ||
|
|
||
| func TestLoadFailsOnPermissionDenied(t *testing.T) { | ||
| dir := t.TempDir() | ||
| path := filepath.Join(dir, "config.json") | ||
| if err := os.WriteFile(path, []byte(`{"port":3050}`), 0644); err != nil { | ||
| t.Fatalf("setup: %v", err) | ||
| } | ||
| if err := os.Chmod(path, 0000); err != nil { | ||
| t.Fatalf("chmod: %v", err) | ||
| } | ||
| t.Cleanup(func() { os.Chmod(path, 0644) }) | ||
|
|
||
| // Skip if running as root (root bypasses file permissions). | ||
| if os.Getuid() == 0 { | ||
| t.Skip("running as root, permission test not applicable") | ||
| } | ||
|
|
||
| _, err := Load(path) | ||
| if err == nil { | ||
| t.Fatal("Load() error = nil, want error for unreadable file") | ||
| } | ||
| } | ||
|
Comment on lines
+26
to
+46
There was a problem hiding this comment.
To test the read failure path in a fully cross-platform and robust manner without needing root/administrator checks, you can pass a directory path (like func TestLoadFailsOnReadError(t *testing.T) {
dir := t.TempDir()
_, err := Load(dir)
if err == nil {
t.Fatal("Load() error = nil, want error when path is a directory")
}
} |
||
|
|
||
| func TestLoadParsesValidJSON(t *testing.T) { | ||
| dir := t.TempDir() | ||
| path := filepath.Join(dir, "config.json") | ||
| data := `{"port":8080,"host":"127.0.0.1","apiBase":"https://custom.api","cc_apiKey":"user_abc123","proxy_token":"tok"}` | ||
| if err := os.WriteFile(path, []byte(data), 0644); err != nil { | ||
| t.Fatalf("setup: %v", err) | ||
| } | ||
|
|
||
| cfg, err := Load(path) | ||
| if err != nil { | ||
| t.Fatalf("Load() error = %v", err) | ||
| } | ||
| if cfg.Port != 8080 { | ||
| t.Fatalf("Port = %d, want 8080", cfg.Port) | ||
| } | ||
| if cfg.Host != "127.0.0.1" { | ||
| t.Fatalf("Host = %q, want 127.0.0.1", cfg.Host) | ||
| } | ||
| if cfg.APIBase != "https://custom.api" { | ||
| t.Fatalf("APIBase = %q, want https://custom.api", cfg.APIBase) | ||
| } | ||
| if cfg.CCAPIKey != "user_abc123" { | ||
| t.Fatalf("CCAPIKey = %q, want user_abc123", cfg.CCAPIKey) | ||
| } | ||
| if cfg.ProxyToken != "tok" { | ||
| t.Fatalf("ProxyToken = %q, want tok", cfg.ProxyToken) | ||
| } | ||
| } | ||
|
|
||
| func TestLoadFailsOnInvalidJSON(t *testing.T) { | ||
| dir := t.TempDir() | ||
| path := filepath.Join(dir, "config.json") | ||
| if err := os.WriteFile(path, []byte(`{invalid json`), 0644); err != nil { | ||
| t.Fatalf("setup: %v", err) | ||
| } | ||
|
|
||
| _, err := Load(path) | ||
| if err == nil { | ||
| t.Fatal("Load() error = nil, want error for invalid JSON") | ||
| } | ||
| } | ||
|
|
||
| func TestLoadEnvOverrides(t *testing.T) { | ||
| t.Setenv("PORT", "9999") | ||
| t.Setenv("HOST", "0.0.0.0") | ||
| t.Setenv("COMMANDCODE_PROXY_TOKEN", "envtoken") | ||
| t.Setenv("LOG_LEVEL", "debug") | ||
|
|
||
| cfg, err := Load(filepath.Join(t.TempDir(), "nonexistent-config-test.json")) | ||
| if err != nil { | ||
| t.Fatalf("Load() error = %v", err) | ||
| } | ||
| if cfg.Port != 9999 { | ||
| t.Fatalf("Port = %d, want 9999 from env", cfg.Port) | ||
| } | ||
| if cfg.ProxyToken != "envtoken" { | ||
| t.Fatalf("ProxyToken = %q, want envtoken from env", cfg.ProxyToken) | ||
| } | ||
| if cfg.LogLevel != "debug" { | ||
| t.Fatalf("LogLevel = %q, want debug from env", cfg.LogLevel) | ||
| } | ||
| } | ||
|
|
||
| func TestValidateRejectsInvalidPort(t *testing.T) { | ||
| cfg := &Config{Port: 0, Host: "0.0.0.0", APIBase: "https://api.test"} | ||
| if err := cfg.Validate(); err == nil { | ||
| t.Fatal("Validate() error = nil, want error for port 0") | ||
| } | ||
| } | ||
|
|
||
| func TestValidateRejectsEmptyHost(t *testing.T) { | ||
| cfg := &Config{Port: 3050, Host: "", APIBase: "https://api.test"} | ||
| if err := cfg.Validate(); err == nil { | ||
| t.Fatal("Validate() error = nil, want error for empty host") | ||
| } | ||
| } | ||
|
|
||
| func TestDefaultModelRefreshInterval(t *testing.T) { | ||
| if defaults.ModelRefreshInterval != 5*time.Minute { | ||
| t.Fatalf("default ModelRefreshInterval = %v, want 5m", defaults.ModelRefreshInterval) | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating a raw
&http.Transport{}from scratch without copyinghttp.DefaultTransportor configuring a customDialContextmeans you lose critical default settings. Specifically, you lose the default 30-second dial timeout, keep-alive settings, TLS handshake timeouts, and system proxy support. This can cause connection attempts to hang indefinitely under poor network conditions.Instead, clone
http.DefaultTransportand customize only the connection pooling fields.