Skip to content

extensions: add EGL_MESA_gl_texture_cubemap_image#165

Open
bl4ckb0ne wants to merge 3 commits intoKhronosGroup:mainfrom
bl4ckb0ne:gl-texture-cubemap-image
Open

extensions: add EGL_MESA_gl_texture_cubemap_image#165
bl4ckb0ne wants to merge 3 commits intoKhronosGroup:mainfrom
bl4ckb0ne:gl-texture-cubemap-image

Conversation

@bl4ckb0ne
Copy link
Copy Markdown
Contributor

@bl4ckb0ne bl4ckb0ne commented Aug 5, 2022 •
edited
Loading

Closes #164, allows the creation of an EGLImage from a GL_TEXTURE_CUBE_MAP.

MESA implementation https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18011

bl4ckb0ne
bl4ckb0ne commented Aug 5, 2022
View reviewed changes
Comment thread extensions/MESA/EGL_MESA_gl_texture_cubemap_image.txt Outdated
@bl4ckb0ne bl4ckb0ne force-pushed the gl-texture-cubemap-image branch from c71a05c to 2960edc Compare August 5, 2022 11:42
@bl4ckb0ne bl4ckb0ne mentioned this pull request Aug 5, 2022
Closed
@bl4ckb0ne bl4ckb0ne force-pushed the gl-texture-cubemap-image branch 3 times, most recently from 4eefa79 to 32f9da2 Compare August 10, 2022 19:56
@stonesthrow
Copy link
Copy Markdown
Contributor

stonesthrow commented Aug 10, 2022

I added a few MESA participants to review.

@fooishbar
Copy link
Copy Markdown
Contributor

fooishbar commented Aug 10, 2022

thanks! I think this is within @jekstrand & @nwnk's remit

@bl4ckb0ne
Copy link
Copy Markdown
Contributor Author

bl4ckb0ne commented Aug 10, 2022

Thanks for pinging the relevant people @fooishbar, I talked with @jekstrand last week about this specific issue

bl4ckb0ne added a commit to bl4ckb0ne/EGL-Registry that referenced this pull request Aug 11, 2022
@bl4ckb0ne
Reserve enums 0x3530-0x353F for MESA (KhronosGroup#165)
6ad15dd 
Signed-off-by: Simon Zeni <simon@bl4ckb0ne.ca>
oddhack pushed a commit that referenced this pull request Aug 11, 2022
@bl4ckb0ne
Reserve enums 0x3530-0x353F for MESA (#165) (#168)
eb056d6 
Signed-off-by: Simon Zeni <simon@bl4ckb0ne.ca>

Signed-off-by: Simon Zeni <simon@bl4ckb0ne.ca>
@bl4ckb0ne bl4ckb0ne force-pushed the gl-texture-cubemap-image branch from 32f9da2 to 59bcb79 Compare August 11, 2022 13:21
stonesthrow
stonesthrow approved these changes Aug 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@stonesthrow stonesthrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfxstrand
Copy link
Copy Markdown

gfxstrand commented Aug 12, 2022

MESA implementation https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18011

Is there meant to be an actual implementation somewhere? All that does is pull in the new XML and headers. I don't see any actual Mesa EGL code.

@bl4ckb0ne
Copy link
Copy Markdown
Contributor Author

bl4ckb0ne commented Aug 12, 2022

I havent pushed yet, I'm working on a piglit test at the same time to validate everything. I'll make a push this afternoon.

@bl4ckb0ne bl4ckb0ne mentioned this pull request Aug 17, 2022
Open
XZiar pushed a commit to XZiar/EGL-Registry that referenced this pull request Aug 23, 2022
@bl4ckb0ne
Reserve enums 0x3530-0x353F for MESA (KhronosGroup#165) (KhronosGroup…
e20565c 
…#168)

Signed-off-by: Simon Zeni <simon@bl4ckb0ne.ca>

Signed-off-by: Simon Zeni <simon@bl4ckb0ne.ca>
@bl4ckb0ne bl4ckb0ne force-pushed the gl-texture-cubemap-image branch from 59bcb79 to 7d5194b Compare September 27, 2022 18:16
stonesthrow
stonesthrow reviewed Sep 29, 2022
View reviewed changes
Comment thread extensions/MESA/EGL_MESA_gl_texture_cubemap_image.txt Outdated
stonesthrow
stonesthrow requested changes Sep 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@stonesthrow stonesthrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"allows adds" in description

@bl4ckb0ne bl4ckb0ne force-pushed the gl-texture-cubemap-image branch from 7d5194b to e2473bf Compare September 30, 2022 10:41
@stonesthrow
Copy link
Copy Markdown
Contributor

stonesthrow commented Sep 30, 2022

Need reviews

@bl4ckb0ne
Copy link
Copy Markdown
Contributor Author

bl4ckb0ne commented Oct 11, 2022 via email

@bl4ckb0ne bl4ckb0ne force-pushed the gl-texture-cubemap-image branch from e2473bf to 3e33351 Compare October 27, 2022 21:03
@bl4ckb0ne
Copy link
Copy Markdown
Contributor Author

bl4ckb0ne commented Oct 28, 2022

Both MESA impl and EGL are up for review

lygstate
lygstate reviewed Oct 29, 2022
View reviewed changes
Comment thread api/egl.xml
@bl4ckb0ne
api/egl.xml: fix indenting issue
8b756c2 
Signed-off-by: Simon Zeni <simon@bl4ckb0ne.ca>
@bl4ckb0ne
extensions: add EGL_MESA_gl_texture_cubemap_image
daa0e36 
Signed-off-by: Simon Zeni <simon@bl4ckb0ne.ca>
@bl4ckb0ne
api: update generated files
955fbc5 
Signed-off-by: Simon Zeni <simon@bl4ckb0ne.ca>
@bl4ckb0ne bl4ckb0ne force-pushed the gl-texture-cubemap-image branch from 3e33351 to 955fbc5 Compare October 31, 2022 14:09
@stonesthrow
Copy link
Copy Markdown
Contributor

stonesthrow commented Oct 31, 2022

Extension is ready for review with a MESA implementation. Please review and approve.

@bl4ckb0ne
Copy link
Copy Markdown
Contributor Author

bl4ckb0ne commented Nov 1, 2022

ping @jekstrand and @nwnk for the mesa impl

@bl4ckb0ne bl4ckb0ne mentioned this pull request Jul 19, 2023
Closed
@oddhack
Copy link
Copy Markdown
Contributor

oddhack commented Jul 16, 2024

@jekstrand @nwnk @stonesthrow could this be progressed? The last state was asking for reviews and that was well over a year ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oddhack oddhack oddhack left review comments

@stonesthrow stonesthrow stonesthrow approved these changes

@cubanismo cubanismo Awaiting requested review from cubanismo

@fooishbar fooishbar Awaiting requested review from fooishbar

@linyaa-kiwi linyaa-kiwi Awaiting requested review from linyaa-kiwi

+1 more reviewer

@lygstate lygstate lygstate left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

eglCreateImage for cubemap textures

6 participants

@bl4ckb0ne @stonesthrow @fooishbar @gfxstrand @oddhack @lygstate