Conversation
If it's absent, the fall back to the method that might give false positives. Issue: https://khanacademy.atlassian.net/browse/FEI-3796
jeresig
approved these changes
Aug 4, 2021
Comment on lines
+80
to
+84
| // uses: jaredly/get-changed-files@absolute | ||
| // id: changed | ||
| // with: | ||
| // format: 'json' | ||
| // absolute: true |
Member
There was a problem hiding this comment.
I assume this is coming in another diff - but why the change to absolute file paths and outputting as JSON?
Contributor
Author
There was a problem hiding this comment.
So:
- outputting as json is more robust
- the get-changed-files action produces files relative to the github base by default; I added the absolute option because that's what the rest of our system expects, and it allows us to run commands from various subdirectories, not just the workspace root.
Comment on lines
+91
to
+92
| const files = JSON.parse(process.env.ALL_CHANGED_FILES) | ||
| return files.filter(path => !isFileIgnored(cwd, path)) |
Member
There was a problem hiding this comment.
You may have to manually run the build/lint process (I see that Prettier hasn't run here).
Contributor
Author
There was a problem hiding this comment.
@jeresig so we don't have it configured on this repo 🙃
I'll add a prettierrc
This was referenced Aug 4, 2021
Merged
jaredly
added a commit
to Khan/eslint-action
that referenced
this pull request
Aug 4, 2021
## Summary: See Khan/actions-utils#14 ## Test plan: I updated the workflow to set up the ALL_CHANGED_FILES variable. Our other workflows that use eslint-action will want to add those setup steps as well. Author: jaredly Reviewers: jeresig, jaredly Required Reviewers: Approved by: jeresig Checks: ❌ lint_and_unit, ✅ autofix Pull request URL: #28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
If it's absent, the fall back to the method that might give false positives.
Issue: https://khanacademy.atlassian.net/browse/FEI-3796
Test plan:
This pull-request shows the new code in action https://github.com/Khan/eslint-action/pull/27/files