Remove git submodules and let cargo mange that#12
Open
shekohex wants to merge 3 commits into
Open
Conversation
Author
|
maybe @soralit can you review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Hello, I did notice that you are using git submodules with a
ssh+git, which is not the best, instead we can let cargo itself manage these dependencies for us.Use cases
I'm building a simple CLI wallet, shekozwallet, and I noticed a few things while working on that wallet is the git submodules issues starts to rise when it comes to CI or machines that does not have SSH agent configured.
With this change, there will be no need for SSH stuff, and it is even simpler to update the dependencies from inside the Cargo.toml itself.