test: align send-budget default assertion with shipped 20x/200 cap - #139
Conversation
The fork.test.ts case asserted maxTotalSends defaults of 300 (50x budgetUsd) and 400 (no budget), but BudgetGuard (core/src/autonomous/lib/budget.ts:64) ships 20x / 200. The suite was red on master; CI did not catch it because the CLI workspace tests are not run in CI. Update the assertions to match the shipped behaviour (120 and 200) so the suite passes.
|
Warning Review limit reached
Next review available in: 53 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
runners/cli/tests/fork.test.tsfails onmaster, so the CLI test suite is red (28/29). CI does not surface this because thetestjob runs only thecoreandsdkworkspaces — the CLI suite is never executed.Root cause
The test asserted
BudgetGuardsend-budget defaults of 300 (50× budgetUsd) and 400 (no budget), but the shipped code incore/src/autonomous/lib/budget.ts:64uses20× budgetUsd(else 200):So
budgetUsd: 6 → 120(not 300) and no-budget→ 200(not 400).Change
Test-only. Assertions + test name updated to match the shipped 20×/200 behaviour (the lower, intended spend ceiling). No production code touched.
How verified
npm test --workspace=@keyvaluesystems/agent-opfor-cli→ green (was failing)npm run typecheck·npm run lint·npm run format:check→ pass--no-verify.Follow-ups (separate PRs)