Repository navigation
Conversation
actions/upload-artifact zips the build output, which drops file modes: every file comes back from download-artifact as 644. The verify step only ran chmod +x on the x86_64 Linux binary (so the --help smoke test could run), and npm publish then packed the other four binaries without the execute bit. On macOS and arm64 Linux, `nestjs-trpc generate` fails with: Failed to execute nestjs-trpc CLI: spawnSync .../native/aarch64-apple-darwin/nestjs-trpc EACCES Every tarball from at least 2.9.1 through 2.13.0 has this shape; only x86_64-unknown-linux-gnu/nestjs-trpc is 755. Move the chmod into the loop so all four Unix binaries are executable before the package is published. Windows does not use the mode bit.
|
@ChazUK is attempting to deploy a commit to the Kevin's Projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #124.
actions/upload-artifactputs the build output into a zip file. The zip file does not keep the mode bits. Thus, each native binary arrives in the publish job with mode 644.The verify step set
+xagain only on the x86_64 Linux binary, because the--helpsmoke test needs it.npm publishthen released the other four binaries without the executable bit. On macOS and on arm64 Linux, the CLI fails withspawnSync ... EACCES.This change moves
chmod +xinto the loop that is already in the workflow. Thus, all four Unix binaries are executable before the publish step. Windows does not use the mode bit, so this change does not touch the.exefile.I checked the published tarballs for 2.9.1, 2.10.0, 2.12.0 and 2.13.0. In each tarball, only
x86_64-unknown-linux-gnu/nestjs-trpchas mode 755.