Fix compilation errors and bugs for modern toolchains#6
Open
andromedus6 wants to merge 1 commit intoKerryL:masterfrom
Open
Fix compilation errors and bugs for modern toolchains#6andromedus6 wants to merge 1 commit intoKerryL:masterfrom
andromedus6 wants to merge 1 commit intoKerryL:masterfrom
Conversation
- Replace deprecated vsprintf with vsnprintf (macOS deprecation) - Fix uint/size_t type mismatch in ExpressionTree::FindEndOfNextTerm - Remove deprecated encoding parameter from wxXmlDocument::Load (wxWidgets 3.3) - Remove dead code (unused variable and loop) in GetControlOnActiveTab - Fix off-by-one in DuplicateGroupsExist (first group was skipped, wrong name in error message) - Guard against log10(0) and log10(negative) in UpdateConversion - Remove unreachable return after throw in GetGroupNode - Replace NULL with nullptr in GetNode Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vsprintfwithvsnprintffor macOS compatibilityuint/size_ttype mismatch in expression parser (always-true comparison on 64-bit)wxXmlDocument::Loadcall for wxWidgets 3.3 compatibilityDuplicateGroupsExistthat skipped the first grouplog10(0)/log10(negative)crash inUpdateConversionTest plan
-Wall -Wextra -Werrorand zero warnings🤖 Generated with Claude Code