Repository navigation
Accept 0x-prefixed hex strings for MDToken inputs - #22
Merged
Merged
Conversation
dnSpy's UI and this server's own signature/error formats show tokens in hex, but token inputs (token / method_token) only parsed decimal uints, forcing LLMs to convert by hand. Route string parsing in ReadOptionalUInt through a new TryParseUInt that takes decimal or 0x-prefixed hex (leading '#' tolerated), declare the 13 token schema properties as integer|string so clients don't reject hex at validation, and cover it with an e2e step feeding decompile_by_token a hex token.
Owner
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dnSpy's UI and this server's own signature/error formats show tokens in hex, but token inputs (token / method_token) only parsed decimal uints, forcing LLMs to convert by hand. Route string parsing in ReadOptionalUInt through a new TryParseUInt that takes decimal or 0x-prefixed hex (leading '#' tolerated), declare the 13 token schema properties as integer|string so clients don't reject hex at validation, and cover it with an e2e step feeding decompile_by_token a hex token.