Skip to content

Build jixia with PhysLib's toolchain + tolerant decode #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gabrielebattimelli merged 1 commit into from
Jun 3, 2026
+12 −5
Merged

Build jixia with PhysLib's toolchain + tolerant decode #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/weekly-index.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,18 @@ jobs:
uses: actions/cache@v4
with:
path: jixia/.lake/build
key: jixia-${{ hashFiles('physlib/lean-toolchain') }}-${{ hashFiles('jixia/lakefile.lean', 'jixia/lakefile.toml') }}
restore-keys: jixia-${{ hashFiles('physlib/lean-toolchain') }}-
# v2: rebuilt against PhysLib's toolchain (see Build jixia below)
key: jixia-v2-${{ hashFiles('physlib/lean-toolchain') }}-${{ hashFiles('jixia/lakefile.lean', 'jixia/lakefile.toml') }}
restore-keys: jixia-v2-${{ hashFiles('physlib/lean-toolchain') }}-

- name: Build jixia
if: steps.check.outputs.has_changes == 'true'
run: cd jixia && lake build
# jixia reads PhysLib's compiled .olean files, which are version-locked
# to PhysLib's Lean toolchain. Build jixia with the same toolchain so the
# olean headers are compatible (otherwise: "incompatible header").
run: |
cp physlib/lean-toolchain jixia/lean-toolchain
cd jixia && lake build
timeout-minutes: 30

- name: Set JIXIA_PATH and LEAN_SYSROOT
Expand Down
5 changes: 3 additions & 2 deletions database/jixia_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,15 @@ def _get_signature(declaration: Declaration, module_content):
if declaration.signature.pp is not None:
return declaration.signature.pp
elif declaration.signature.range is not None:
return module_content[declaration.signature.range.as_slice()].decode()
# A range may not land on a UTF-8 boundary; don't let it abort the load.
return module_content[declaration.signature.range.as_slice()].decode(errors="replace")
else:
return ""


def _get_value(declaration: Declaration, module_content):
if declaration.value is not None and declaration.value.range is not None:
return module_content[declaration.value.range.as_slice()].decode()
return module_content[declaration.value.range.as_slice()].decode(errors="replace")
else:
return None

Expand Down
Loading