fix(profiles): include CoreOS profiles in tier3 matrix (catalog↔matrix consistency)#49
Merged
Merged
Conversation
…atrix consistency) The profile catalog lists fedora-coreos-stable-6.14 and rhcos-4.16-5.14 under Tier 3, but matrices/tier3-cloud-native.yaml did not reference them — unlike the sibling non-runnable profiles (bottlerocket/talos/flatcar), which are in the matrix as required: false. Add both CoreOS profiles the same way (non-blocking; ExecutionTransport still reports them unsupported, so nothing claims they run), and list their missing cache images alongside the siblings. No change to runnability: CoreOS remains Ignition-gated and unsupported, and RHCOS/OpenShift is still deliberately absent from the README "Distributions covered" section. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an inconsistency introduced in #48:
docs/profile-catalog.mdlistsfedora-coreos-stable-6.14andrhcos-4.16-5.14under Tier 3, butmatrices/tier3-cloud-native.yamldid not include them — even though the sibling non-runnable profiles (Bottlerocket, Talos, Flatcar) are in that matrix asrequired: false.Change
matrices/tier3-cloud-native.yamlasrequired: false, matching the sibling convention.Not changed (deliberately)
ExecutionTransport()still returnsunsupported, so nothing claims RHCOS/FCOS actually boot and load/attach. The matrix entries are non-blocking.Verify
vm/profiles/<id>.yaml.go test ./internal/matrix ./internal/vm ./internal/runnergreen.🤖 Generated with Claude Code